From: Tejun Heo <tj@kernel.org>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
Andrea Righi <arighi@nvidia.com>,
Changwoo Min <changwoo@igalia.com>,
Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
Chia-Ping Tsai <chia7712@gmail.com>
Subject: Re: [PATCH] sched_ext: Fix scx_bpf_dsq_move_to_local___v2() to handle SCX_DSQ_GLOBAL
Date: Thu, 26 Mar 2026 01:22:59 -1000 [thread overview]
Message-ID: <acUXEy9NUVMb40Lh@slm.duckdns.org> (raw)
In-Reply-To: <20260326091756.816828-1-yphbchou0911@gmail.com>
On Thu, Mar 26, 2026 at 05:17:30PM +0800, Cheng-Yang Chou wrote:
> scx_bpf_dsq_move_to_local___v2() called find_user_dsq() for all dsq_id
> values, but find_user_dsq() only searches the rhashtable of user-created
> DSQs. SCX_DSQ_GLOBAL is a builtin DSQ stored in the per-node pnode and
> not in the rhashtable, so passing SCX_DSQ_GLOBAL caused find_user_dsq()
> to return NULL, triggering scx_error() and aborting the scheduler.
>
> Add an explicit check for SCX_DSQ_GLOBAL and use find_global_dsq() in
> that case, matching the pattern used in find_dsq_for_dispatch().
This is intentional. Both global and local DSQs are terminal and don't
provide interface for direct control once tasks are queued.
Thanks.
--
tejun
next prev parent reply other threads:[~2026-03-26 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 9:17 [PATCH] sched_ext: Fix scx_bpf_dsq_move_to_local___v2() to handle SCX_DSQ_GLOBAL Cheng-Yang Chou
2026-03-26 11:22 ` Tejun Heo [this message]
2026-03-26 14:24 ` Cheng-Yang Chou
2026-03-26 19:46 ` Tejun Heo
2026-03-26 19:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acUXEy9NUVMb40Lh@slm.duckdns.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=changwoo@igalia.com \
--cc=chia7712@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=sched-ext@lists.linux.dev \
--cc=void@manifault.com \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.