All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: sched-ext@lists.linux.dev, David Vernet <void@manifault.com>,
	Andrea Righi <arighi@nvidia.com>,
	Changwoo Min <changwoo@igalia.com>,
	Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
	Chia-Ping Tsai <chia7712@gmail.com>
Subject: Re: [PATCH] sched_ext: Fix scx_bpf_dsq_move_to_local___v2() to handle SCX_DSQ_GLOBAL
Date: Thu, 26 Mar 2026 09:46:39 -1000	[thread overview]
Message-ID: <acWNH2Kp2k6K__Zj@slm.duckdns.org> (raw)
In-Reply-To: <2bpxb64ymbxgtzodc5bxdmh5w7klr3xokyt7wccb2lzn3arxwp@yhu3jj4ury7w>

Hello,

On Thu, Mar 26, 2026 at 10:24:54PM +0800, Cheng-Yang Chou wrote:
> Since the error message only says "invalid DSQ ID" without distinguishing
> between "DSQ not found" and "intentionally unsupported terminal DSQ",
> would it be worth adding a comment to clarify the design intent?

Yeah, sure. Note that. Local (along with user DSQs) now support
reenqueueing. When a task gets in a local DSQ, it either gets picked up by
the CPU for execution, gets dequeued for e.g. property changes, or can be
reenqueued. However, the BPF sched can directly iterate local DSQs or move
tasks in them. Global DSQ is similar but dosen't support reenq, mostly
because it's difficult to define the scope as SCX_DSQ_GLOBAL maps to
multiple currently per-node DSQs. This may change in the future.

Thanks.

-- 
tejun

  reply	other threads:[~2026-03-26 19:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-26  9:17 [PATCH] sched_ext: Fix scx_bpf_dsq_move_to_local___v2() to handle SCX_DSQ_GLOBAL Cheng-Yang Chou
2026-03-26 11:22 ` Tejun Heo
2026-03-26 14:24   ` Cheng-Yang Chou
2026-03-26 19:46     ` Tejun Heo [this message]
2026-03-26 19:47       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acWNH2Kp2k6K__Zj@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=arighi@nvidia.com \
    --cc=changwoo@igalia.com \
    --cc=chia7712@gmail.com \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=sched-ext@lists.linux.dev \
    --cc=void@manifault.com \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.