Re: [PATCH v2 02/14] iommufd: Extend attach/detach_hwpt callbacks to support pasid

[Nicolin Chen <nicolinc@nvidia.com>]

On Thu, Mar 26, 2026 at 05:11:16AM -0400, Zhenzhong Duan wrote:
> @@ -138,14 +138,16 @@ struct HostIOMMUDeviceIOMMUFDClass {
>       *
>       * @idev: host IOMMU device backed by IOMMUFD backend.

Not commenting against this patch, but I just found the "host IOMMU
device" and the "HostIOMMUDeviceIOMMUFD" a bit ambiguous. It's not
an "IOMMU device" right? Perhaps somebody can help me understand :)

> +     * @pasid: target pasid of attach.
> +     *

How about "target pasid of the device to be attached"?

The uAPI docs has the narrative "pasid of this device", which makes
it clearer. 

>       * @hwpt_id: ID of IOMMUFD hardware page table.
>       *
>       * @errp: pass an Error out when attachment fails.
>       *
>       * Returns: true on success, false on failure.
>       */
> -    bool (*attach_hwpt)(HostIOMMUDeviceIOMMUFD *idev, uint32_t hwpt_id,
> -                        Error **errp);
> +    bool (*attach_hwpt)(HostIOMMUDeviceIOMMUFD *idev, uint32_t pasid,
> +                        uint32_t hwpt_id, Error **errp);
>      /**
>       * @detach_hwpt: detach host IOMMU device from IOMMUFD hardware page table.
>       * VFIO and VDPA device can have different implementation.
> @@ -154,15 +156,19 @@ struct HostIOMMUDeviceIOMMUFDClass {
>       *
>       * @idev: host IOMMU device backed by IOMMUFD backend.
>       *
> +     * @pasid: target pasid of detach.

Ditto

Otherwise,

Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>