All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Leonard Lausen <leonard@lausen.nl>
Cc: "Luka Gejak" <luka.gejak@linux.dev>,
	"David Härdeman" <david@hardeman.nu>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO
Date: Tue, 17 Nov 2026 06:59:17 +0000	[thread overview]
Message-ID: <acd95beb9e704a51a00e1b3a18420c06@realtek.com> (raw)
In-Reply-To: <20261116205739.462458-4-leonard@lausen.nl>

Leonard Lausen <leonard@lausen.nl> wrote:

> @@ -285,14 +285,11 @@ static void rtw_ops_configure_filter(struct ieee80211_hw *hw,
> 
>         mutex_lock(&rtwdev->mutex);
> 
> +       rtwdev->hal.rx_control = *new_flags & FIF_CONTROL;
> +
>         rtw_leave_lps_deep(rtwdev);
> 
> -       if (changed_flags & FIF_CONTROL) {
> -               if (*new_flags & FIF_CONTROL)
> -                       rtw_write16(rtwdev, REG_RXFLTMAP1, 0xffff);
> -               else
> -                       rtw_write16(rtwdev, REG_RXFLTMAP1, rtwdev->hal.rxfltmap1);
> -       }
> +       rtw_update_rx_filter(rtwdev);

a blank line.

>         if (changed_flags & FIF_ALLMULTI) {
>                 if (*new_flags & FIF_ALLMULTI)
>                         rtwdev->hal.rcr |= BIT_AM;

[...]

> diff --git a/drivers/net/wireless/realtek/rtw88/reg.h b/drivers/net/wireless/realtek/rtw88/reg.h
> index afcdb66fdb9a1..8e220580be4f8 100644
> --- a/drivers/net/wireless/realtek/rtw88/reg.h
> +++ b/drivers/net/wireless/realtek/rtw88/reg.h
> @@ -587,6 +587,10 @@
> 
>  #define REG_RXFLTMAP0          0x06A0
>  #define REG_RXFLTMAP1          0x06A2
> +#define BIT_RXFLTMAP1_BACK     BIT(9)
> +#define BIT_RXFLTMAP1_RTS      BIT(11)
> +#define BIT_RXFLTMAP1_CTS      BIT(12)
> +#define BIT_RXFLTMAP1_ACK      BIT(13)

In reverse order, see existing pattern.

>  #define REG_RXFLTMAP2          0x06A4
>  #define REG_RXFLTMAP4          0x068A
>  #define REG_BT_COEX_TABLE0     0x06C0

[...]

> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> index 09315d23e2c40..5a5215c05276c 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> @@ -2096,7 +2096,17 @@ static int rtw8822c_mac_init(struct rtw_dev *rtwdev)
>         rtw_write8(rtwdev, REG_WMAC_TRXPTCL_CTL_H  + 2, WLAN_BAR_ACK_TYPE);
>         rtw_write16(rtwdev, REG_RXFLTMAP0, WLAN_RX_FILTER0);
>         rtwdev->hal.rxfltmap1 = WLAN_RX_FILTER1;
> -       rtw_write16(rtwdev, REG_RXFLTMAP1, rtwdev->hal.rxfltmap1);
> +       if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO) {
> +               /*
> +                * Hardware handles these frames; retain BAR and PS-Poll for

I prefer the wording "not forward".

> +                * mac80211. The common writer preserves FIF_CONTROL requests.
> +                */
> +               rtwdev->hal.rxfltmap1 &= ~(BIT_RXFLTMAP1_BACK |
> +                                          BIT_RXFLTMAP1_RTS |
> +                                          BIT_RXFLTMAP1_CTS |
> +                                          BIT_RXFLTMAP1_ACK);
> +       }
> +       rtw_update_rx_filter(rtwdev);
>         rtw_write16(rtwdev, REG_RXFLTMAP2, WLAN_RX_FILTER2);
>         rtw_write32(rtwdev, REG_RCR, WLAN_RCR_CFG);
>         rtw_write8(rtwdev, REG_RX_PKT_LIMIT, WLAN_RXPKT_MAX_SZ_512);
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> b/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> index 5ffa29d18168e..7aacdb64c6e3c 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> @@ -513,7 +513,7 @@ static void rtw88xxa_init_wmac_setting(struct rtw_dev *rtwdev)
>  {
>         rtw_write16(rtwdev, REG_RXFLTMAP0, 0xffff);
>         rtwdev->hal.rxfltmap1 = 0x0400;
> -       rtw_write16(rtwdev, REG_RXFLTMAP1, rtwdev->hal.rxfltmap1);
> +       rtw_update_rx_filter(rtwdev);
>         rtw_write16(rtwdev, REG_RXFLTMAP2, 0xffff);
> 
>         rtw_write32(rtwdev, REG_MAR, 0xffffffff);


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Ping-Ke Shih <pkshih@realtek.com>
To: Leonard Lausen <leonard@lausen.nl>
Cc: "Luka Gejak" <luka.gejak@linux.dev>,
	"David Härdeman" <david@hardeman.nu>,
	"Shawn Lin" <shawn.lin@rock-chips.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO
Date: Tue, 17 Nov 2026 06:59:17 +0000	[thread overview]
Message-ID: <acd95beb9e704a51a00e1b3a18420c06@realtek.com> (raw)
In-Reply-To: <20261116205739.462458-4-leonard@lausen.nl>

Leonard Lausen <leonard@lausen.nl> wrote:

> @@ -285,14 +285,11 @@ static void rtw_ops_configure_filter(struct ieee80211_hw *hw,
> 
>         mutex_lock(&rtwdev->mutex);
> 
> +       rtwdev->hal.rx_control = *new_flags & FIF_CONTROL;
> +
>         rtw_leave_lps_deep(rtwdev);
> 
> -       if (changed_flags & FIF_CONTROL) {
> -               if (*new_flags & FIF_CONTROL)
> -                       rtw_write16(rtwdev, REG_RXFLTMAP1, 0xffff);
> -               else
> -                       rtw_write16(rtwdev, REG_RXFLTMAP1, rtwdev->hal.rxfltmap1);
> -       }
> +       rtw_update_rx_filter(rtwdev);

a blank line.

>         if (changed_flags & FIF_ALLMULTI) {
>                 if (*new_flags & FIF_ALLMULTI)
>                         rtwdev->hal.rcr |= BIT_AM;

[...]

> diff --git a/drivers/net/wireless/realtek/rtw88/reg.h b/drivers/net/wireless/realtek/rtw88/reg.h
> index afcdb66fdb9a1..8e220580be4f8 100644
> --- a/drivers/net/wireless/realtek/rtw88/reg.h
> +++ b/drivers/net/wireless/realtek/rtw88/reg.h
> @@ -587,6 +587,10 @@
> 
>  #define REG_RXFLTMAP0          0x06A0
>  #define REG_RXFLTMAP1          0x06A2
> +#define BIT_RXFLTMAP1_BACK     BIT(9)
> +#define BIT_RXFLTMAP1_RTS      BIT(11)
> +#define BIT_RXFLTMAP1_CTS      BIT(12)
> +#define BIT_RXFLTMAP1_ACK      BIT(13)

In reverse order, see existing pattern.

>  #define REG_RXFLTMAP2          0x06A4
>  #define REG_RXFLTMAP4          0x068A
>  #define REG_BT_COEX_TABLE0     0x06C0

[...]

> diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> index 09315d23e2c40..5a5215c05276c 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c
> @@ -2096,7 +2096,17 @@ static int rtw8822c_mac_init(struct rtw_dev *rtwdev)
>         rtw_write8(rtwdev, REG_WMAC_TRXPTCL_CTL_H  + 2, WLAN_BAR_ACK_TYPE);
>         rtw_write16(rtwdev, REG_RXFLTMAP0, WLAN_RX_FILTER0);
>         rtwdev->hal.rxfltmap1 = WLAN_RX_FILTER1;
> -       rtw_write16(rtwdev, REG_RXFLTMAP1, rtwdev->hal.rxfltmap1);
> +       if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO) {
> +               /*
> +                * Hardware handles these frames; retain BAR and PS-Poll for

I prefer the wording "not forward".

> +                * mac80211. The common writer preserves FIF_CONTROL requests.
> +                */
> +               rtwdev->hal.rxfltmap1 &= ~(BIT_RXFLTMAP1_BACK |
> +                                          BIT_RXFLTMAP1_RTS |
> +                                          BIT_RXFLTMAP1_CTS |
> +                                          BIT_RXFLTMAP1_ACK);
> +       }
> +       rtw_update_rx_filter(rtwdev);
>         rtw_write16(rtwdev, REG_RXFLTMAP2, WLAN_RX_FILTER2);
>         rtw_write32(rtwdev, REG_RCR, WLAN_RCR_CFG);
>         rtw_write8(rtwdev, REG_RX_PKT_LIMIT, WLAN_RXPKT_MAX_SZ_512);
> diff --git a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> b/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> index 5ffa29d18168e..7aacdb64c6e3c 100644
> --- a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> +++ b/drivers/net/wireless/realtek/rtw88/rtw88xxa.c
> @@ -513,7 +513,7 @@ static void rtw88xxa_init_wmac_setting(struct rtw_dev *rtwdev)
>  {
>         rtw_write16(rtwdev, REG_RXFLTMAP0, 0xffff);
>         rtwdev->hal.rxfltmap1 = 0x0400;
> -       rtw_write16(rtwdev, REG_RXFLTMAP1, rtwdev->hal.rxfltmap1);
> +       rtw_update_rx_filter(rtwdev);
>         rtw_write16(rtwdev, REG_RXFLTMAP2, 0xffff);
> 
>         rtw_write32(rtwdev, REG_MAR, 0xffffffff);


  parent reply	other threads:[~2026-11-17  7:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:57 [PATCH rtw-next v3 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead Leonard Lausen
2026-11-16 20:57 ` Leonard Lausen
2026-11-16 20:57 ` [PATCH rtw-next v3 1/2] wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO Leonard Lausen
2026-11-16 20:57   ` Leonard Lausen
2026-11-17  5:43   ` Luka Gejak
2026-11-17  5:43     ` Luka Gejak
2026-11-17  6:59   ` Ping-Ke Shih [this message]
2026-11-17  6:59     ` Ping-Ke Shih
2026-11-16 20:57 ` [PATCH rtw-next v3 2/2] wifi: rtw88: sdio: combine free TX page register reads Leonard Lausen
2026-11-16 20:57   ` Leonard Lausen
2026-11-17  5:43   ` Luka Gejak
2026-11-17  5:43     ` Luka Gejak
2026-11-17  7:09   ` Ping-Ke Shih
2026-11-17  7:09     ` Ping-Ke Shih
2026-11-16 21:46 ` [PATCH rtw-next v3 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead Luka Gejak
2026-11-16 21:46   ` Luka Gejak
2026-11-17  0:54   ` Ping-Ke Shih
2026-11-17  0:54     ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=acd95beb9e704a51a00e1b3a18420c06@realtek.com \
    --to=pkshih@realtek.com \
    --cc=david@hardeman.nu \
    --cc=heiko@sntech.de \
    --cc=leonard@lausen.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luka.gejak@linux.dev \
    --cc=shawn.lin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.