From: Yury Norov <ynorov@nvidia.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "Simon Horman" <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Airlie" <airlied@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Yury Norov" <yury.norov@gmail.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
"David Laight" <david.laight.linux@gmail.com>
Subject: Re: [PATCH v2 4/4] drm/xe: switch xe_pagefault_queue_init() to using bitmap_weighted_or()
Date: Sat, 28 Mar 2026 17:57:55 -0400 [thread overview]
Message-ID: <achO43f7IA22uD19@yury> (raw)
In-Reply-To: <51b0f779-4070-44f1-b136-77737da6dbaf@intel.com>
On Thu, Mar 05, 2026 at 02:40:53PM -0800, Tony Nguyen wrote:
>
>
> On 3/4/2026 3:43 AM, Simon Horman wrote:
> > On Sun, Mar 01, 2026 at 08:11:58PM -0500, Yury Norov wrote:
> > > The function calls bitmap_or() immediately followed by bitmap_weight().
> > > Switch to using the dedicated bitmap_weighted_or() and save one bitmap
> > > traverse.
> > >
> > > Signed-off-by: Yury Norov <ynorov@nvidia.com>
> >
> > It's not entirely clear to me why this patch is included in a patchset
> > for the ice driver.
> >
> > And it's also not clear to me why, but allmodconfigs - fo4 at least x86_32
> > and x86_64 - fail with this patch applied to net-next [1].
> >
> > ERROR: modpost: "__bitmap_weighted_or" [drivers/gpu/drm/xe/xe.ko] undefined!
> >
> > [1] 2b12ffb66955 ("net: mana: Trigger VF reset/recovery on health check failure due to HWC timeout")
>
> I'm also seeing the same error and no apparent reason. Since this doesn't
> seem dependent on the others, I'll take the other 3 and this can get
> sent/resolved separately.
That's because the symbol is not exported, and the driver is build as
module.
It's already fixed in -next: 95d324fb1b484 ("bitmap: add test_zero_nbits()").
Let me know if you want me to send the fix as a separate patch in your
tree. Or I can take this patch in my branch, if you give me your tags.
Thanks,
Yury
WARNING: multiple messages have this Message-ID (diff)
From: Yury Norov via Intel-wired-lan <intel-wired-lan@osuosl.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: "Simon Horman" <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Airlie" <airlied@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Matthew Brost" <matthew.brost@intel.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Yury Norov" <yury.norov@gmail.com>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org,
"David Laight" <david.laight.linux@gmail.com>
Subject: Re: [Intel-wired-lan] [PATCH v2 4/4] drm/xe: switch xe_pagefault_queue_init() to using bitmap_weighted_or()
Date: Sat, 28 Mar 2026 17:57:55 -0400 [thread overview]
Message-ID: <achO43f7IA22uD19@yury> (raw)
In-Reply-To: <51b0f779-4070-44f1-b136-77737da6dbaf@intel.com>
On Thu, Mar 05, 2026 at 02:40:53PM -0800, Tony Nguyen wrote:
>
>
> On 3/4/2026 3:43 AM, Simon Horman wrote:
> > On Sun, Mar 01, 2026 at 08:11:58PM -0500, Yury Norov wrote:
> > > The function calls bitmap_or() immediately followed by bitmap_weight().
> > > Switch to using the dedicated bitmap_weighted_or() and save one bitmap
> > > traverse.
> > >
> > > Signed-off-by: Yury Norov <ynorov@nvidia.com>
> >
> > It's not entirely clear to me why this patch is included in a patchset
> > for the ice driver.
> >
> > And it's also not clear to me why, but allmodconfigs - fo4 at least x86_32
> > and x86_64 - fail with this patch applied to net-next [1].
> >
> > ERROR: modpost: "__bitmap_weighted_or" [drivers/gpu/drm/xe/xe.ko] undefined!
> >
> > [1] 2b12ffb66955 ("net: mana: Trigger VF reset/recovery on health check failure due to HWC timeout")
>
> I'm also seeing the same error and no apparent reason. Since this doesn't
> seem dependent on the others, I'll take the other 3 and this can get
> sent/resolved separately.
That's because the symbol is not exported, and the driver is build as
module.
It's already fixed in -next: 95d324fb1b484 ("bitmap: add test_zero_nbits()").
Let me know if you want me to send the fix as a separate patch in your
tree. Or I can take this patch in my branch, if you give me your tags.
Thanks,
Yury
next prev parent reply other threads:[~2026-03-28 21:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 1:11 [Intel-wired-lan] [PATCH v2 0/4] ice: use better bitmap API Yury Norov via Intel-wired-lan
2026-03-02 1:11 ` Yury Norov
2026-03-02 1:11 ` [Intel-wired-lan] [PATCH v2 1/4] bitmap: introduce bitmap_weighted_xor() Yury Norov via Intel-wired-lan
2026-03-02 1:11 ` Yury Norov
2026-03-02 7:12 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-02 7:12 ` Loktionov, Aleksandr
2026-03-02 1:11 ` [Intel-wired-lan] [PATCH v2 2/4] ice: use bitmap_weighted_xor() in ice_find_free_recp_res_idx() Yury Norov via Intel-wired-lan
2026-03-02 1:11 ` Yury Norov
2026-03-02 7:13 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-02 7:13 ` Loktionov, Aleksandr
2026-04-09 3:52 ` Rinitha, SX
2026-04-09 3:52 ` Rinitha, SX
2026-03-02 1:11 ` [Intel-wired-lan] [PATCH v2 3/4] ice: use bitmap_empty() in ice_vf_has_no_qs_ena Yury Norov via Intel-wired-lan
2026-03-02 1:11 ` Yury Norov
2026-03-02 7:14 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-02 7:14 ` Loktionov, Aleksandr
2026-03-27 10:37 ` Romanowski, Rafal
2026-03-27 10:37 ` Romanowski, Rafal
2026-03-02 1:11 ` [Intel-wired-lan] [PATCH v2 4/4] drm/xe: switch xe_pagefault_queue_init() to using bitmap_weighted_or() Yury Norov via Intel-wired-lan
2026-03-02 1:11 ` Yury Norov
2026-03-02 7:14 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-03-02 7:14 ` Loktionov, Aleksandr
2026-03-02 19:49 ` Matthew Brost
2026-03-02 19:49 ` Matthew Brost
2026-03-04 11:43 ` [Intel-wired-lan] " Simon Horman
2026-03-04 11:43 ` Simon Horman
2026-03-05 22:40 ` [Intel-wired-lan] " Tony Nguyen
2026-03-05 22:40 ` Tony Nguyen
2026-03-28 21:57 ` Yury Norov [this message]
2026-03-28 21:57 ` [Intel-wired-lan] " Yury Norov via Intel-wired-lan
2026-03-30 20:47 ` anthony.l.nguyen
2026-03-30 20:47 ` [Intel-wired-lan] " anthony.l.nguyen
2026-03-02 1:17 ` ✗ CI.checkpatch: warning for ice: use better bitmap API Patchwork
2026-03-02 1:19 ` ✓ CI.KUnit: success " Patchwork
2026-03-02 23:01 ` [Intel-wired-lan] [PATCH v2 0/4] " Jacob Keller
2026-03-02 23:01 ` Jacob Keller
2026-04-02 0:08 ` Yury Norov
2026-04-02 0:08 ` [Intel-wired-lan] " Yury Norov via Intel-wired-lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=achO43f7IA22uD19@yury \
--to=ynorov@nvidia.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=matthew.brost@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.