From: Dan Carpenter <error27@gmail.com>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Cc: linux-staging@lists.linux.dev, Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/2] media: atomisp: fix potential NULL pointer dereference in configure_isp_from_args()
Date: Mon, 30 Mar 2026 12:35:30 +0300 [thread overview]
Message-ID: <acopy6nyxSb16J8N@stanley.mountain> (raw)
In-Reply-To: <20260328192721.255493-2-azpijr@gmail.com>
On Sat, Mar 28, 2026 at 08:21:37PM +0100, Jose A. Perez de Azpillaga wrote:
> The function configure_isp_from_args() incorrectly dereferences
> args->delay_frames[0] to configure cropping without checking if the
> pointer is valid. However, as noted in a FIXME comment later in the
> same function, delay_frames can be NULL in certain pipeline
> configurations.
The comment comes later in the function and it says "FIXME:
args->delay_frames can be NULL here". "args->delay_frames" is
different from "args->delay_frames[0]". Obviously
args->delay_frames can't actually be NULL there since we
dereference it here so the comment is wrong.
If the correct response to the FIXME were just to add a NULL
check then the original author probably would have done that.
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-30 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 19:21 [PATCH v1 0/2] media: atomisp: harden and clean up isp configuration Jose A. Perez de Azpillaga
2026-03-28 19:21 ` [PATCH v1 1/2] media: atomisp: fix potential NULL pointer dereference in configure_isp_from_args() Jose A. Perez de Azpillaga
2026-03-30 8:59 ` Andy Shevchenko
2026-03-31 5:57 ` Jose A. Perez de Azpillaga
2026-03-31 7:04 ` Andy Shevchenko
2026-03-30 9:35 ` Dan Carpenter [this message]
2026-03-31 6:07 ` Jose A. Perez de Azpillaga
2026-03-31 6:13 ` Jose A. Perez de Azpillaga
2026-03-28 19:21 ` [PATCH v1 2/2] media: atomisp: remove redundant call to ia_css_output0_configure() Jose A. Perez de Azpillaga
2026-03-30 9:01 ` Andy Shevchenko
2026-03-31 6:03 ` Jose A. Perez de Azpillaga
2026-03-31 7:08 ` Andy Shevchenko
2026-03-30 9:35 ` Dan Carpenter
2026-03-31 6:11 ` Jose A. Perez de Azpillaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acopy6nyxSb16J8N@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=azpijr@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.