From: Dan Carpenter <error27@gmail.com>
To: "Jose A. Perez de Azpillaga" <azpijr@gmail.com>
Cc: linux-staging@lists.linux.dev, Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] media: atomisp: remove redundant call to ia_css_output0_configure()
Date: Mon, 30 Mar 2026 12:35:34 +0300 [thread overview]
Message-ID: <acortY2LJ9f1K4ju@stanley.mountain> (raw)
In-Reply-To: <20260328192721.255493-3-azpijr@gmail.com>
On Sat, Mar 28, 2026 at 08:21:38PM +0100, Jose A. Perez de Azpillaga wrote:
> The function configure_isp_from_args() contained a duplicate call to
> ia_css_output0_configure() using the same output frame index. Remove
> the redundant call to simplify the configuration path.
>
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
> ---
This feels like a guess work patch. Sure, it looks like duplicate
code but duplicate code isn't always wrong. How do you know which
call to remove? How do you know that it's not a copy and paste error
and the right fix is just to change the code instead of deleting it?
Patch 1 felt like an AI patch, and this patch feels even more strongly
like an AI patch.
Please don't send guess work patches or if you do add a giant comment
at the bottom saying --- "This patch is a GUESS. Review carefully!
Untested"
regards,
dan carpenter
next prev parent reply other threads:[~2026-03-30 9:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 19:21 [PATCH v1 0/2] media: atomisp: harden and clean up isp configuration Jose A. Perez de Azpillaga
2026-03-28 19:21 ` [PATCH v1 1/2] media: atomisp: fix potential NULL pointer dereference in configure_isp_from_args() Jose A. Perez de Azpillaga
2026-03-30 8:59 ` Andy Shevchenko
2026-03-31 5:57 ` Jose A. Perez de Azpillaga
2026-03-31 7:04 ` Andy Shevchenko
2026-03-30 9:35 ` Dan Carpenter
2026-03-31 6:07 ` Jose A. Perez de Azpillaga
2026-03-31 6:13 ` Jose A. Perez de Azpillaga
2026-03-28 19:21 ` [PATCH v1 2/2] media: atomisp: remove redundant call to ia_css_output0_configure() Jose A. Perez de Azpillaga
2026-03-30 9:01 ` Andy Shevchenko
2026-03-31 6:03 ` Jose A. Perez de Azpillaga
2026-03-31 7:08 ` Andy Shevchenko
2026-03-30 9:35 ` Dan Carpenter [this message]
2026-03-31 6:11 ` Jose A. Perez de Azpillaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acortY2LJ9f1K4ju@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=azpijr@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.