Re: [PATCH 1/3] qemu/atomic: Rename atomic128-cas.h headers using .h.inc suffix

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 12/12/24 16:11, Richard Henderson wrote:
> On 12/12/24 09:09, Philippe Mathieu-Daudé wrote:
>> On 12/12/24 16:02, Richard Henderson wrote:
>>> On 12/12/24 08:10, Philippe Mathieu-Daudé wrote:
>>>> Since commit 139c1837db ("meson: rename included C source files
>>>> to .c.inc"), QEMU standard procedure for included C files is to
>>>> use *.c.inc.
>>>>
>>>> Besides, since commit 6a0057aa22 ("docs/devel: make a statement
>>>> about includes") this is documented in the Coding Style:
>>>>
>>>>    If you do use template header files they should be named with
>>>>    the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
>>>>    being included for expansion.
>>>>
>>>> Therefore rename 'atomic128-cas.h' as 'atomic128-cas.h.inc'.
>>>
>>> But these are not templates, nor included multiple times, so...
>>> I don't get it.
>> I wanted to avoid including "qemu/atomic.h" in each of them due to:
>>
>>      host/include/generic/host/atomic128-cas.h:23:11: error: call to 
>> undeclared function 'qatomic_cmpxchg__nocheck'; ISO C99 and later do 
>> not support implicit function declarations [-Wimplicit-function- 
>> declaration]
>>         23 |     r.i = qatomic_cmpxchg__nocheck(ptr_align, c.i, n.i);
>>            |           ^
>>      1 error generated.
> 
> And why would you ever have that?

To have "not template" headers self-contained; but I'm fine discarding
these 2 patches and keeping the last one of this series.