From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] qemu/atomic: Rename atomic128-cas.h headers using .h.inc suffix
Date: Thu, 12 Dec 2024 09:02:18 -0600 [thread overview]
Message-ID: <ee831fff-eb0a-4e56-8eee-99222e55d707@linaro.org> (raw)
In-Reply-To: <20241212141018.59428-2-philmd@linaro.org>
On 12/12/24 08:10, Philippe Mathieu-Daudé wrote:
> Since commit 139c1837db ("meson: rename included C source files
> to .c.inc"), QEMU standard procedure for included C files is to
> use *.c.inc.
>
> Besides, since commit 6a0057aa22 ("docs/devel: make a statement
> about includes") this is documented in the Coding Style:
>
> If you do use template header files they should be named with
> the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are
> being included for expansion.
>
> Therefore rename 'atomic128-cas.h' as 'atomic128-cas.h.inc'.
But these are not templates, nor included multiple times, so...
I don't get it.
r~
next prev parent reply other threads:[~2024-12-12 15:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 14:10 [PATCH 0/3] qemu/atomic: Header cleanups Philippe Mathieu-Daudé
2024-12-12 14:10 ` [PATCH 1/3] qemu/atomic: Rename atomic128-cas.h headers using .h.inc suffix Philippe Mathieu-Daudé
2024-12-12 15:02 ` Richard Henderson [this message]
2024-12-12 15:09 ` Philippe Mathieu-Daudé
2024-12-12 15:11 ` Richard Henderson
2024-12-12 15:17 ` Philippe Mathieu-Daudé
2024-12-12 15:20 ` Richard Henderson
2024-12-12 14:10 ` [PATCH 2/3] qemu/atomic: Rename atomic128-ldst.h " Philippe Mathieu-Daudé
2024-12-12 14:10 ` [PATCH 3/3] qemu/atomic128: Include missing 'qemu/atomic.h' header Philippe Mathieu-Daudé
2024-12-12 15:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee831fff-eb0a-4e56-8eee-99222e55d707@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.