From: Christoph Hellwig <hch@infradead.org>
To: Ravi Singh <ravising@redhat.com>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
djwong@kernel.org, dchinner@redhat.com, esandeen@redhat.com,
cem@kernel.org
Subject: Re: [PATCH] xfs: flush delalloc blocks on ENOSPC when creating symlinks
Date: Wed, 15 Apr 2026 00:20:46 -0700 [thread overview]
Message-ID: <ad88TluB4FIP3yJV@infradead.org> (raw)
In-Reply-To: <20260415071657.23412-1-ravising@redhat.com>
On Wed, Apr 15, 2026 at 07:16:57AM +0000, Ravi Singh wrote:
> When creating symlinks on a nearly-full XFS filesystem,
> xfs_symlink() fails with ENOSPC even though space could be
> reclaimed from speculative preallocations. xfs_create() already
> handles this by flushing outstanding delalloc blocks via
> xfs_flush_inodes() and retrying the transaction allocation, but
> xfs_symlink() returns the error immediately.
>
> Add the same ENOSPC flush+retry logic to xfs_symlink() so that
> symlink creation behaves consistently with file creation.
While we're at it - do we also want it for tempfiles and scrub?
i.e., should we move this logic into xfs_trans_alloc_icreate,
similar to the quota logic?
next prev parent reply other threads:[~2026-04-15 7:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 7:16 [PATCH] xfs: flush delalloc blocks on ENOSPC when creating symlinks Ravi Singh
2026-04-15 7:20 ` Christoph Hellwig [this message]
2026-04-15 13:24 ` Ravi Singh
2026-04-15 14:14 ` Eric Sandeen
2026-04-16 5:13 ` Christoph Hellwig
2026-04-20 9:58 ` Ravi Singh
2026-04-20 10:06 ` [PATCH v2] xfs: flush delalloc blocks on ENOSPC in xfs_trans_alloc_icreate Ravi Singh
2026-04-22 6:27 ` Christoph Hellwig
2026-04-22 7:42 ` Ravi Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad88TluB4FIP3yJV@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=esandeen@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ravising@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.