Re: [PATCH] xfs: flush delalloc blocks on ENOSPC when creating symlinks

[Christoph Hellwig <hch@infradead.org>]

On Wed, Apr 15, 2026 at 06:54:00PM +0530, Ravi Singh wrote:
> > While we're at it - do we also want it for tempfiles and scrub?
> > i.e., should we move this logic into xfs_trans_alloc_icreate,
> > similar to the quota logic?
> >
> tmpfiles and scrub tempfiles are created without
> directory entries, so they don't need a new directory block
> allocation and don't hit this ENOSPC path.


But we still ned the ialloc space reservation for all these cases.

> As for moving the logic into xfs_trans_alloc_icreate(),
> xfs_flush_inodes() is a heavier operation (sync_inodes_sb).
> Pushing it down into xfs_trans_alloc_icreate() would make every
> caller pay for that flush, including paths that don't need it.

Only if we git enospc and need to restart the underlying
xfs_trans_alloc call, similar to how it handles quotas.