All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Vincent Legoll <legoll@online.fr>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
	Yixun Lan <dlan@kernel.org>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
Date: Mon, 6 Apr 2026 17:42:05 +0200	[thread overview]
Message-ID: <adPUTRAlzGBs2wQG@aurel32.net> (raw)
In-Reply-To: <b7e182f9-8bd8-40e6-acaa-dc6e556f2a53@online.fr>

Hi Vincent,

On 2026-04-06 11:46, Vincent Legoll wrote:
> Hello Aurelien,
> 
> I tested this on top of next-20260403 + the USB3 patch series v8 from Han
> Gao:
> 
> $ git log --oneline | head -7
> 05054ef4ae1d mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
> 5f56e5402644 riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2
> 5b0a2f3f8fa6 riscv: dts: spacemit: Define the P1 PMIC regulators for
> OrangePi RV2
> a05128fa7d3e riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
> 2febe6e6ee6e Add linux-next specific files for 20260403
> 8ff4869c6f24 Merge branch 'for-next' of
> https://github.com/hisilicon/linux-hisi.git
> e7d27cf6777b Merge branch 'next' of
> https://git.kernel.org/pub/scm/linux/kernel/git/devsec/tsm.git
> 
> Without your patch the board hang on reset. With the patch applied, it
> reboots but there's a WARNING, see the attached dmesg.
> 
> Tell me if there's a new iteration to test, and/or if you want me testing it
> in a different way.

Yes, as written in the original mail, this patchset depends on PIO 
support in the spacemit I2C driver:
https://lore.kernel.org/lkml/20260207-b4-k3-i2c-pio-v7-2-626942d94d91@linux.spacemit.com/

Without it, you might get this warning message and reboot is not 100% 
reliable. I still believe it's better than no reboot support at all.

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Aurelien Jarno <aurelien@aurel32.net>
To: Vincent Legoll <legoll@online.fr>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
	Yixun Lan <dlan@kernel.org>,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev
Subject: Re: [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
Date: Mon, 6 Apr 2026 17:42:05 +0200	[thread overview]
Message-ID: <adPUTRAlzGBs2wQG@aurel32.net> (raw)
In-Reply-To: <b7e182f9-8bd8-40e6-acaa-dc6e556f2a53@online.fr>

Hi Vincent,

On 2026-04-06 11:46, Vincent Legoll wrote:
> Hello Aurelien,
> 
> I tested this on top of next-20260403 + the USB3 patch series v8 from Han
> Gao:
> 
> $ git log --oneline | head -7
> 05054ef4ae1d mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip
> 5f56e5402644 riscv: dts: spacemit: Enable USB3.0/PCIe on OrangePi RV2
> 5b0a2f3f8fa6 riscv: dts: spacemit: Define the P1 PMIC regulators for
> OrangePi RV2
> a05128fa7d3e riscv: dts: spacemit: Enable i2c8 adapter for OrangePi RV2
> 2febe6e6ee6e Add linux-next specific files for 20260403
> 8ff4869c6f24 Merge branch 'for-next' of
> https://github.com/hisilicon/linux-hisi.git
> e7d27cf6777b Merge branch 'next' of
> https://git.kernel.org/pub/scm/linux/kernel/git/devsec/tsm.git
> 
> Without your patch the board hang on reset. With the patch applied, it
> reboots but there's a WARNING, see the attached dmesg.
> 
> Tell me if there's a new iteration to test, and/or if you want me testing it
> in a different way.

Yes, as written in the original mail, this patchset depends on PIO 
support in the spacemit I2C driver:
https://lore.kernel.org/lkml/20260207-b4-k3-i2c-pio-v7-2-626942d94d91@linux.spacemit.com/

Without it, you might get this warning message and reboot is not 100% 
reliable. I still believe it's better than no reboot support at all.

Regards
Aurelien

-- 
Aurelien Jarno                          GPG: 4096R/1DDD8C9B
aurelien@aurel32.net                     http://aurel32.net

  reply	other threads:[~2026-04-06 15:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 16:50 [RESEND][PATCH v5] mfd: simple-mfd-i2c: add a reboot cell for the SpacemiT P1 chip Aurelien Jarno
2026-04-01 16:50 ` Aurelien Jarno
2026-04-06  9:46 ` Vincent Legoll
2026-04-06  9:46   ` Vincent Legoll
2026-04-06 15:42   ` Aurelien Jarno [this message]
2026-04-06 15:42     ` Aurelien Jarno
2026-04-06 21:55     ` Vincent Legoll
2026-04-06 21:55       ` Vincent Legoll
2026-04-08  2:48       ` Troy Mitchell
2026-04-08  2:48         ` Troy Mitchell
2026-04-10 20:38 ` Aurelien Jarno
2026-04-10 20:38   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adPUTRAlzGBs2wQG@aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=dlan@kernel.org \
    --cc=lee@kernel.org \
    --cc=legoll@online.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=spacemit@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.