All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] f2fs: do not support mmap write for large folio
Date: Tue, 7 Apr 2026 22:58:11 +0000	[thread overview]
Message-ID: <adWMAzmaHiYzSTzN@google.com> (raw)
In-Reply-To: <adSTUszGSlEK_IBv@infradead.org>

On 04/06, Christoph Hellwig wrote:
> On Mon, Apr 06, 2026 at 03:49:40PM +0000, Jaegeuk Kim wrote:
> > Let's check mmmap writes onto the large folio.
> 
> Why?  And how is this not breaking applications?

Since we only support the large folio on the read case.

> 
> > 
> > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> > ---
> >  fs/f2fs/file.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> > index 2c4880f24b54..edfc3a374c40 100644
> > --- a/fs/f2fs/file.c
> > +++ b/fs/f2fs/file.c
> > @@ -82,7 +82,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf)
> >  	int err = 0;
> >  	vm_fault_t ret;
> >  
> > -	if (unlikely(IS_IMMUTABLE(inode)))
> > +	if (mapping_large_folio_support(inode->i_mapping))
> >  		return VM_FAULT_SIGBUS;
> >  
> >  	if (is_inode_flag_set(inode, FI_COMPRESS_RELEASED)) {
> > -- 
> > 2.53.0.1213.gd9a14994de-goog
> > 
> > 
> ---end quoted text---


  reply	other threads:[~2026-04-07 22:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-06 15:49 [f2fs-dev] [PATCH] f2fs: do not support mmap write for large folio Jaegeuk Kim via Linux-f2fs-devel
2026-04-06 15:57 ` Daeho Jeong
2026-04-06 16:57   ` Jaegeuk Kim via Linux-f2fs-devel
2026-04-07  5:17 ` Christoph Hellwig
2026-04-07 22:58   ` Jaegeuk Kim [this message]
2026-04-08  5:03     ` Christoph Hellwig
2026-04-08 14:07       ` David Hildenbrand (Arm)
2026-04-08 18:08         ` Jaegeuk Kim
2026-04-13 19:22           ` David Hildenbrand (Arm)
2026-04-08 18:13 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-09  5:40   ` Christoph Hellwig
2026-04-09  5:40     ` Christoph Hellwig
2026-04-10  1:15     ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-10  1:15       ` Jaegeuk Kim
2026-04-13 11:27   ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-04-13 22:47     ` Jaegeuk Kim via Linux-f2fs-devel
2026-04-13 22:46   ` [f2fs-dev] [PATCH v4] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-14  8:23     ` Chao Yu via Linux-f2fs-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adWMAzmaHiYzSTzN@google.com \
    --to=jaegeuk@kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.