From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] f2fs: do not support mmap write for large folio
Date: Fri, 10 Apr 2026 01:15:32 +0000 [thread overview]
Message-ID: <adhPNLtbAlqI8F3l@google.com> (raw)
In-Reply-To: <adc7yo1_sr_eeV33@infradead.org>
On 04/08, Christoph Hellwig wrote:
> [adding back fsdevel and mm to the discussion]
>
> On Wed, Apr 08, 2026 at 06:13:06PM +0000, Jaegeuk Kim wrote:
> > Let's check mmap writes onto the large folio, since we don't support writing
> > large folios.
>
> What does this fix? As state in the previous round of discussion f2fs
> only support large folios for immutable files, how do you get ->mkwrite
> called for them.
I'm approaching this as a safeguard first, since in any buggy case, this will
crash the filesystem.
>
> The only way I can think of that is when clearing the immutable flag,
> but simply rejecting writes with SIGBUS after that seems like it's
> breaking the expected API, and I don't see handling for normal writes
> after that either.
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] f2fs: do not support mmap write for large folio
Date: Fri, 10 Apr 2026 01:15:32 +0000 [thread overview]
Message-ID: <adhPNLtbAlqI8F3l@google.com> (raw)
In-Reply-To: <adc7yo1_sr_eeV33@infradead.org>
On 04/08, Christoph Hellwig wrote:
> [adding back fsdevel and mm to the discussion]
>
> On Wed, Apr 08, 2026 at 06:13:06PM +0000, Jaegeuk Kim wrote:
> > Let's check mmap writes onto the large folio, since we don't support writing
> > large folios.
>
> What does this fix? As state in the previous round of discussion f2fs
> only support large folios for immutable files, how do you get ->mkwrite
> called for them.
I'm approaching this as a safeguard first, since in any buggy case, this will
crash the filesystem.
>
> The only way I can think of that is when clearing the immutable flag,
> but simply rejecting writes with SIGBUS after that seems like it's
> breaking the expected API, and I don't see handling for normal writes
> after that either.
next prev parent reply other threads:[~2026-04-10 1:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-06 15:49 [f2fs-dev] [PATCH] f2fs: do not support mmap write for large folio Jaegeuk Kim via Linux-f2fs-devel
2026-04-06 15:57 ` Daeho Jeong
2026-04-06 16:57 ` Jaegeuk Kim via Linux-f2fs-devel
2026-04-07 5:17 ` Christoph Hellwig
2026-04-07 22:58 ` Jaegeuk Kim
2026-04-08 5:03 ` Christoph Hellwig
2026-04-08 14:07 ` David Hildenbrand (Arm)
2026-04-08 18:08 ` Jaegeuk Kim
2026-04-13 19:22 ` David Hildenbrand (Arm)
2026-04-08 18:13 ` [f2fs-dev] [PATCH v3] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-09 5:40 ` Christoph Hellwig
2026-04-09 5:40 ` Christoph Hellwig
2026-04-10 1:15 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2026-04-10 1:15 ` Jaegeuk Kim
2026-04-13 11:27 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2026-04-13 22:47 ` Jaegeuk Kim via Linux-f2fs-devel
2026-04-13 22:46 ` [f2fs-dev] [PATCH v4] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-14 8:23 ` Chao Yu via Linux-f2fs-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adhPNLtbAlqI8F3l@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.