From: Christoph Hellwig <hch@infradead.org>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Jens Axboe <axboe@kernel.dk>,
drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-block@vger.kernel.org,
Joel Colledge <joel.colledge@linbit.com>,
an Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
nvdimm@lists.linux.dev
Subject: Re: [PATCH 08/20] drbd: add DAX/PMEM support for metadata access
Date: Tue, 7 Apr 2026 22:46:26 -0700 [thread overview]
Message-ID: <adXrslkhromDtu37@infradead.org> (raw)
In-Reply-To: <20260327223820.2244227-9-christoph.boehmwalder@linbit.com>
Adding the dax maintainers and they really need to review this.
> + long want = (drbd_md_last_sector(bdev) + 1 - first_sector) >> (PAGE_SHIFT - SECTOR_SHIFT);
> + pgoff_t pgoff = first_sector >> (PAGE_SHIFT - SECTOR_SHIFT);
> + long md_offset_byte = (bdev->md.md_offset - first_sector) << SECTOR_SHIFT;
> + long al_offset_byte = (al_sector - first_sector) << SECTOR_SHIFT;
You really want helpers to make all these unit conversions maintainable.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Christoph Böhmwalder" <christoph.boehmwalder@linbit.com>
Cc: Jens Axboe <axboe@kernel.dk>,
nvdimm@lists.linux.dev, Dave Jiang <dave.jiang@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Lars Ellenberg <lars.ellenberg@linbit.com>,
an Williams <dan.j.williams@intel.com>,
drbd-dev@lists.linbit.com
Subject: Re: [PATCH 08/20] drbd: add DAX/PMEM support for metadata access
Date: Tue, 7 Apr 2026 22:46:26 -0700 [thread overview]
Message-ID: <adXrslkhromDtu37@infradead.org> (raw)
In-Reply-To: <20260327223820.2244227-9-christoph.boehmwalder@linbit.com>
Adding the dax maintainers and they really need to review this.
> + long want = (drbd_md_last_sector(bdev) + 1 - first_sector) >> (PAGE_SHIFT - SECTOR_SHIFT);
> + pgoff_t pgoff = first_sector >> (PAGE_SHIFT - SECTOR_SHIFT);
> + long md_offset_byte = (bdev->md.md_offset - first_sector) << SECTOR_SHIFT;
> + long al_offset_byte = (al_sector - first_sector) << SECTOR_SHIFT;
You really want helpers to make all these unit conversions maintainable.
next prev parent reply other threads:[~2026-04-08 5:46 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 22:38 [PATCH 00/20] DRBD 9 rework Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 01/20] drbd: mark as BROKEN during " Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 02/20] drbd: extend wire protocol definitions for DRBD 9 Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-28 14:13 ` kernel test robot
2026-03-28 14:13 ` kernel test robot
2026-03-27 22:38 ` [PATCH 03/20] drbd: introduce DRBD 9 on-disk metadata format Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 04/20] drbd: add transport layer abstraction Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 05/20] drbd: add TCP transport implementation Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 06/20] drbd: add RDMA " Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-04-08 5:42 ` Christoph Hellwig
2026-04-08 5:42 ` Christoph Hellwig
2026-04-08 12:01 ` Christoph Böhmwalder
2026-04-08 12:01 ` Christoph Böhmwalder
2026-04-12 16:36 ` Leon Romanovsky
2026-03-27 22:38 ` [PATCH 07/20] drbd: add load-balancing TCP transport Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 08/20] drbd: add DAX/PMEM support for metadata access Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-04-08 5:46 ` Christoph Hellwig [this message]
2026-04-08 5:46 ` Christoph Hellwig
2026-03-27 22:38 ` [PATCH 09/20] drbd: add optional compatibility layer for DRBD 8.4 Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 10/20] drbd: rename drbd_worker.c to drbd_sender.c Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 11/20] drbd: rework sender for DRBD 9 multi-peer Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 12/20] drbd: replace per-device state model with multi-peer data structures Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 13/20] drbd: rewrite state machine for DRBD 9 multi-peer clusters Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 14/20] drbd: rework activity log and bitmap for multi-peer replication Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 15/20] drbd: rework request processing for DRBD 9 multi-peer IO Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 16/20] drbd: rework module core for DRBD 9 transport and multi-peer Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 17/20] drbd: rework receiver for DRBD 9 transport and multi-peer protocol Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 18/20] drbd: rework netlink management interface for DRBD 9 Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 19/20] drbd: update monitoring interfaces for multi-peer topology Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-27 22:38 ` [PATCH 20/20] drbd: remove BROKEN for DRBD Christoph Böhmwalder
2026-03-27 22:38 ` Christoph Böhmwalder
2026-03-28 12:21 ` kernel test robot
2026-03-28 12:21 ` kernel test robot
2026-03-28 14:20 ` kernel test robot
2026-03-28 14:20 ` kernel test robot
2026-04-03 1:30 ` [PATCH 00/20] DRBD 9 rework Jens Axboe
2026-04-03 1:30 ` Jens Axboe
2026-04-03 13:24 ` Christoph Böhmwalder
2026-04-03 13:24 ` Christoph Böhmwalder
2026-04-03 13:26 ` Jens Axboe
2026-04-08 5:17 ` Christoph Hellwig
2026-04-08 5:17 ` Christoph Hellwig
2026-04-08 12:58 ` Jens Axboe
2026-04-08 12:58 ` Jens Axboe
2026-04-09 6:40 ` Christoph Hellwig
2026-04-09 6:40 ` Christoph Hellwig
2026-04-10 1:14 ` Jens Axboe
2026-04-10 1:14 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adXrslkhromDtu37@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=christoph.boehmwalder@linbit.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=drbd-dev@lists.linbit.com \
--cc=joel.colledge@linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=philipp.reisner@linbit.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.