Re: [PATCH v4 0/3] staging: rtl8723bs: cleanup booleans and style

[Dan Carpenter <error27@gmail.com>]

On Sun, Apr 05, 2026 at 07:01:32PM +0300, Andrei Khomenkov wrote:
> This series of patches cleans up the rtl8723bs driver code to improve
> readability and alignment with the Linux kernel coding style. The
> changes affect if-statements and while-loops, including:
>  - Simplifying boolean comparisons by removing redundant ' == true',
>    ' != true', and ' == false'.
>  - Adding spaces around bitwise operators.
>  - Removing redundant parentheses.
>  - Wrapping logical operators to the previous line.
>  
> Changes are limited to 'if' and 'while' statements, where both logic
> and style are cleaned up at once. No functional changes are intended.
> 
> Link: https://lore.kernel.org/linux-staging/20260402150429.14761-1-khomenkov@mailbox.org
> 
> v4:
>  - Combined logic and style cleanups into single commits to
>    avoid fragmented changes, as suggested by Dan Carpenter.

I'm sorry I wasn't clear enough...  I meant if you change:

	if ((foo == false) || (bar == true)) {

Then don't leave the extra parentheses:

 Bad:	if ((!foo) || (bar)) {
Good:   if (!foo || bar) {

However, if you leave a comparison operation then *DO* leave the
parentheses.  Also moving the && around or deleting white space
is unrelated.  Don't do unrelated things.

However in the case of the parentheses it *IS* related because now
the parentheses look crazy.  You *HAVE* to make that kind of change.
The one thing per patch rule cuts both ways, we don't want two things
per patch but we also don't want half a thing per patch.

regards,
dan carpenter