Re: [PATCH 1/2] coresight: etm4x: fix inconsistencies with sysfs configration

[Yeoreum Yun <yeoreum.yun@arm.com>]

Hi Suzuki,

[...]

>
> >
> > To resolve these inconsistencies, the configuration should be separated into:
> >
> >    - active_config, which represents the currently applied configuration
>
> To be more precise, it is the "Applied configuration for the current
> session"

Thanks for suggestion. I'll change it.

>
> >    - config, which stores the settings configured via sysfs.
>
> While we are at it, should we stop using the drvdata->config for the
> "capabilities" for the ETM (e.g., TRCSSCSRn in ss_status ?) Instead
> we could save it in "drvdata->ss_status". This keeps everything
> separated:
>
> 1. Boot time probed capabilities of ETM
> 2. Sysfs configuration for the next Run
> 3. Current active configuration for the ETM (sysfs or perf)

Agree. with the Leo's suggestion, I'll change it.

Thanks!

[...]