All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yeoreum Yun <yeoreum.yun@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, mike.leach@linaro.org,
	james.clark@linaro.org, alexander.shishkin@linux.intel.com,
	leo.yan@arm.com
Subject: Re: [PATCH 1/2] coresight: etm4x: fix inconsistencies with sysfs configration
Date: Wed, 8 Apr 2026 18:39:37 +0100	[thread overview]
Message-ID: <adaS2YNppLFMzKbv@e129823.arm.com> (raw)
In-Reply-To: <f62c7138-bddc-4bf1-932d-bafa683f5ee0@arm.com>

Hi Suzuki,

[...]

> >    - config, which stores the settings configured via sysfs.
>
> While we are at it, should we stop using the drvdata->config for the
> "capabilities" for the ETM (e.g., TRCSSCSRn in ss_status ?) Instead
> we could save it in "drvdata->ss_status". This keeps everything
> separated:

Hmm, if we think the drvdata->ss_status as "capabilities",
I think we doesn't need to save/restore ss_status in
etm4_disable_hw()/etm4_enable_hw() since cpu idle doesn't use both
and other bits (STATUS and PENDING) should be cleared when new session
is started regardless of perf or sysfs mode.

Am I missing something?

--
Sincerely,
Yeoreum Yun


  parent reply	other threads:[~2026-04-08 17:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 18:17 [PATCH 0/2] fix inconsistencies with sysfs configuration in etm Yeoreum Yun
2026-03-17 18:17 ` [PATCH 1/2] coresight: etm4x: fix inconsistencies with sysfs configration Yeoreum Yun
2026-04-01 16:14   ` Suzuki K Poulose
2026-04-08  9:07     ` Yeoreum Yun
2026-04-08 17:39     ` Yeoreum Yun [this message]
2026-04-07 14:30   ` Leo Yan
2026-04-08  9:17     ` Yeoreum Yun
2026-04-08 11:02     ` Yeoreum Yun
2026-03-17 18:17 ` [PATCH 2/2] coresight: etm3x: " Yeoreum Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adaS2YNppLFMzKbv@e129823.arm.com \
    --to=yeoreum.yun@arm.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=james.clark@linaro.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.