[PATCH for 11.0] util: fix missing aio_wait_kick sym in qemu guest agent only build

[PATCH for 11.0] util: fix missing aio_wait_kick sym in qemu guest agent only build

[Daniel P. Berrangé]

Configure QEMU with

 --disable-system --disable-user --disable-tools --enable-guest-agent

and the build with fail with

  FAILED: [code=1] qga/qemu-ga
  /usr/bin/ld: libqemuutil.a.p/qapi_qmp-dispatch.c.o: in function `do_qmp_dispatch_bh':
  /var/home/berrange/src/virt/qemu/build/../qapi/qmp-dispatch.c:140:(.text+0x5c): undefined reference to `aio_wait_kick'

This aio_kick() usage was recently introduced in qmp-dispatch.c
without updating the build logic.

Fixes commit fc1a2ec7da531223b3473185dc2584f8a7c6c659
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 util/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/meson.build b/util/meson.build
index 33132c04ad..b2166ac1d5 100644
--- a/util/meson.build
+++ b/util/meson.build
@@ -79,6 +79,7 @@ endif
 
 if have_block or have_ga
   util_ss.add(files('aiocb.c', 'async.c'))
+  util_ss.add(files('aio-wait.c'))
   util_ss.add(files('base64.c'))
   util_ss.add(files('main-loop.c'))
   util_ss.add(files('qemu-coroutine.c', 'qemu-coroutine-lock.c', 'qemu-coroutine-io.c'))
@@ -87,7 +88,6 @@ if have_block or have_ga
   util_ss.add(files('qemu-sockets.c'))
 endif
 if have_block
-  util_ss.add(files('aio-wait.c'))
   util_ss.add(files('buffer.c'))
   util_ss.add(files('bufferiszero.c'))
   util_ss.add(files('hbitmap.c'))
-- 
2.53.0

Re: [PATCH for 11.0] util: fix missing aio_wait_kick sym in qemu guest agent only build

[Michael Tokarev]

On 07.04.2026 18:22, Daniel P. Berrangé wrote:
> Configure QEMU with
> 
>   --disable-system --disable-user --disable-tools --enable-guest-agent
> 
> and the build with fail with
> 
>    FAILED: [code=1] qga/qemu-ga
>    /usr/bin/ld: libqemuutil.a.p/qapi_qmp-dispatch.c.o: in function `do_qmp_dispatch_bh':
>    /var/home/berrange/src/virt/qemu/build/../qapi/qmp-dispatch.c:140:(.text+0x5c): undefined reference to `aio_wait_kick'
> 
> This aio_kick() usage was recently introduced in qmp-dispatch.c
> without updating the build logic.
> 
> Fixes commit fc1a2ec7da531223b3473185dc2584f8a7c6c659
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

It is exactly the same change as suggested by Kevin today,
and exactly the same

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

from me.

Thanks,

/mjt

Re: [PATCH for 11.0] util: fix missing aio_wait_kick sym in qemu guest agent only build

[Kevin Wolf]

Am 07.04.2026 um 17:22 hat Daniel P. Berrangé geschrieben:
> Configure QEMU with
> 
>  --disable-system --disable-user --disable-tools --enable-guest-agent
> 
> and the build with fail with
> 
>   FAILED: [code=1] qga/qemu-ga
>   /usr/bin/ld: libqemuutil.a.p/qapi_qmp-dispatch.c.o: in function `do_qmp_dispatch_bh':
>   /var/home/berrange/src/virt/qemu/build/../qapi/qmp-dispatch.c:140:(.text+0x5c): undefined reference to `aio_wait_kick'
> 
> This aio_kick() usage was recently introduced in qmp-dispatch.c
> without updating the build logic.
> 
> Fixes commit fc1a2ec7da531223b3473185dc2584f8a7c6c659
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Pretty much the same as what I suggested in the pull request thread,
just in a separate line instead of adding it to the previous one and as
a proper patch. Thanks, saves me the work to write a proper commit
messsage!

Reviewed-by: Kevin Wolf <kwolf@redhat.com>

Re: [PATCH for 11.0] util: fix missing aio_wait_kick sym in qemu guest agent only build

[Philippe Mathieu-Daudé]

On 7/4/26 17:22, Daniel P. Berrangé wrote:
> Configure QEMU with
> 
>   --disable-system --disable-user --disable-tools --enable-guest-agent
> 
> and the build with fail with
> 
>    FAILED: [code=1] qga/qemu-ga
>    /usr/bin/ld: libqemuutil.a.p/qapi_qmp-dispatch.c.o: in function `do_qmp_dispatch_bh':
>    /var/home/berrange/src/virt/qemu/build/../qapi/qmp-dispatch.c:140:(.text+0x5c): undefined reference to `aio_wait_kick'
> 
> This aio_kick() usage was recently introduced in qmp-dispatch.c
> without updating the build logic.
> 
> Fixes commit fc1a2ec7da531223b3473185dc2584f8a7c6c659
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   util/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>