All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, masahisa.kojima@linaro.org,
	devicetree@vger.kernel.org, linux-integrity@vger.kernel.org,
	peterhuewe@gmx.de, jgg@ziepe.ca
Subject: Re: [PATCH v2 2/2] tpm: tis: add support for MMIO TPM on SynQuacer
Date: Thu, 23 Jan 2020 14:27:19 +0200	[thread overview]
Message-ID: <ada03416b1b362fa255feb45257414655d8ab023.camel@linux.intel.com> (raw)
In-Reply-To: <20200114141647.109347-3-ardb@kernel.org>

On Tue, 2020-01-14 at 15:16 +0100, Ard Biesheuvel wrote:
> When fitted, the SynQuacer platform exposes its SPI TPM via a MMIO
> window that is backed by the SPI command sequencer in the SPI bus
> controller. This arrangement has the limitation that only byte size
> accesses are supported, and so we'll need to provide a separate set
> of read and write accessors that take this into account.

What is SynQuacer platform?

I'm also missing a resolution why tpm_tis.c is extended to handle both
and not add tpm_tis_something.c instead. It does not follow the pattern
we have in place (e.g. look up tpm_tis_spi.c).

/Jarkko


WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Ard Biesheuvel <ardb@kernel.org>, linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, jgg@ziepe.ca,
	masahisa.kojima@linaro.org, linux-integrity@vger.kernel.org,
	peterhuewe@gmx.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] tpm: tis: add support for MMIO TPM on SynQuacer
Date: Thu, 23 Jan 2020 14:27:19 +0200	[thread overview]
Message-ID: <ada03416b1b362fa255feb45257414655d8ab023.camel@linux.intel.com> (raw)
In-Reply-To: <20200114141647.109347-3-ardb@kernel.org>

On Tue, 2020-01-14 at 15:16 +0100, Ard Biesheuvel wrote:
> When fitted, the SynQuacer platform exposes its SPI TPM via a MMIO
> window that is backed by the SPI command sequencer in the SPI bus
> controller. This arrangement has the limitation that only byte size
> accesses are supported, and so we'll need to provide a separate set
> of read and write accessors that take this into account.

What is SynQuacer platform?

I'm also missing a resolution why tpm_tis.c is extended to handle both
and not add tpm_tis_something.c instead. It does not follow the pattern
we have in place (e.g. look up tpm_tis_spi.c).

/Jarkko


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-01-23 12:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-14 14:16 [PATCH v2 0/2] synquacer: add TPM support Ard Biesheuvel
2020-01-14 14:16 ` Ard Biesheuvel
2020-01-14 14:16 ` [PATCH v2 1/2] dt-bindings: tpm-tis-mmio: add compatible string for SynQuacer TPM Ard Biesheuvel
2020-01-14 14:16   ` Ard Biesheuvel
2020-01-21 22:23   ` Rob Herring
2020-01-21 22:23     ` Rob Herring
2020-01-23 12:22   ` Jarkko Sakkinen
2020-01-23 12:22     ` Jarkko Sakkinen
2020-01-23 12:23     ` Ard Biesheuvel
2020-01-23 12:23       ` Ard Biesheuvel
2020-01-14 14:16 ` [PATCH v2 2/2] tpm: tis: add support for MMIO TPM on SynQuacer Ard Biesheuvel
2020-01-14 14:16   ` Ard Biesheuvel
2020-01-23 12:27   ` Jarkko Sakkinen [this message]
2020-01-23 12:27     ` Jarkko Sakkinen
2020-01-23 12:29     ` Ard Biesheuvel
2020-01-23 12:29       ` Ard Biesheuvel
2020-01-30  8:37       ` Jarkko Sakkinen
2020-01-30  8:37         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada03416b1b362fa255feb45257414655d8ab023.camel@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahisa.kojima@linaro.org \
    --cc=peterhuewe@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.