All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Joachim Fenkes <fenkes@de.ibm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>,
	OF-EWG <ewg@lists.openfabrics.org>,
	LinuxPPC-Dev <linuxppc-dev@ozlabs.org>,
	Christoph Raisch <raisch@de.ibm.com>,
	Marcus Eder <meder@de.ibm.com>,
	OF-General <general@lists.openfabrics.org>,
	Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH] IB/ehca: Serialize HCA-related hCalls if necessary
Date: Wed, 12 Dec 2007 12:29:09 -0800	[thread overview]
Message-ID: <ada3au78xnu.fsf@cisco.com> (raw)
In-Reply-To: <200712101859.11218.fenkes@de.ibm.com> (Joachim Fenkes's message of "Mon, 10 Dec 2007 18:59:10 +0100")

thanks, applied.

With your next batch of patches for 2.6.25, could you clean up:

 > --- a/drivers/infiniband/hw/ehca/hcp_if.c
 > +++ b/drivers/infiniband/hw/ehca/hcp_if.c
 > @@ -89,6 +89,7 @@
 >  #define HCALL9_REGS_FORMAT HCALL7_REGS_FORMAT " r11=%lx r12=%lx"
 >  
 >  static DEFINE_SPINLOCK(hcall_lock);
 > +extern int ehca_lock_hcalls;

and move that extern declaration into an appropriate header file?

Thanks...

WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Joachim Fenkes <fenkes@de.ibm.com>
Cc: "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"OF-General" <general@lists.openfabrics.org>,
	Roland Dreier <rolandd@cisco.com>,
	"OF-EWG" <ewg@lists.openfabrics.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"Hoang-Nam Nguyen" <hnguyen@de.ibm.com>,
	Christoph Raisch <raisch@de.ibm.com>,
	Stefan Roscher <stefan.roscher@de.ibm.com>,
	Marcus Eder <meder@de.ibm.com>
Subject: Re: [PATCH] IB/ehca: Serialize HCA-related hCalls if necessary
Date: Wed, 12 Dec 2007 12:29:09 -0800	[thread overview]
Message-ID: <ada3au78xnu.fsf@cisco.com> (raw)
In-Reply-To: <200712101859.11218.fenkes@de.ibm.com> (Joachim Fenkes's message of "Mon, 10 Dec 2007 18:59:10 +0100")

thanks, applied.

With your next batch of patches for 2.6.25, could you clean up:

 > --- a/drivers/infiniband/hw/ehca/hcp_if.c
 > +++ b/drivers/infiniband/hw/ehca/hcp_if.c
 > @@ -89,6 +89,7 @@
 >  #define HCALL9_REGS_FORMAT HCALL7_REGS_FORMAT " r11=%lx r12=%lx"
 >  
 >  static DEFINE_SPINLOCK(hcall_lock);
 > +extern int ehca_lock_hcalls;

and move that extern declaration into an appropriate header file?

Thanks...

  reply	other threads:[~2007-12-12 20:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-10 17:59 [PATCH] IB/ehca: Serialize HCA-related hCalls if necessary Joachim Fenkes
2007-12-10 17:59 ` Joachim Fenkes
2007-12-12 20:29 ` Roland Dreier [this message]
2007-12-12 20:29   ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada3au78xnu.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=arnd@arndb.de \
    --cc=ewg@lists.openfabrics.org \
    --cc=fenkes@de.ibm.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=meder@de.ibm.com \
    --cc=raisch@de.ibm.com \
    --cc=stefan.roscher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.