From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Moni Shoua <monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
Cc: Alekseys Senin <alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
"ewg@openfabrics.org"
<ewg-G2znmakfqn7U1rindQTSdQ@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tziporet Koren <tziporet-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
Yiftah Shahar <yiftahs-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Subject: Re: [ewg] [PATCH v4] IB Core: RAW ETH support
Date: Wed, 23 Jun 2010 10:31:52 -0700 [thread overview]
Message-ID: <ada4ogtvenr.fsf@roland-alpha.cisco.com> (raw)
In-Reply-To: <4C18E557.5050804-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org> (Moni Shoua's message of "Wed, 16 Jun 2010 17:53:11 +0300")
> There is no qp type IBV_QPT_RAW_ETY in user space (at least not in the definitions
> coming with libibverbs). In fact, libibverbs that comes with OFED defines (in verbs.h)
> a qp type called IBV_QPT_RAW_ETT which equals to 7.
> The patch that is under discussion here adds a new qp type IB_QPT_RAW_ETH and equals it to 7
> to match the definition in user space. This indeed changes the value of IB_QPT_RAW_ETY to 8
> but I don't see who can be affected since
> 1. No user space program that uses IB_QPT_RAW_ETY exists
> 2. kernel is compiled as one piece of code.
Why renumber the _ETY enum? Maybe it doesn't break anything serious but
why risk it?
--
Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> || For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/index.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-06-23 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E113D394D7C5DB4F8FF691FA7EE9DB4439A76E8632@MTLMAIL.mtl.com>
[not found] ` <1276513450.30132.51.camel@alst60.voltaire.com>
[not found] ` <1276513450.30132.51.camel-uOVkuFIEnOODI2cvxHXf6UEOCMrvLtNR@public.gmane.org>
2010-06-15 21:14 ` [ewg] [PATCH v4] IB Core: RAW ETH support Roland Dreier
[not found] ` <aday6eguhfn.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-06-16 14:09 ` Steve Wise
[not found] ` <4C18DB37.6050501-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-06-16 15:47 ` Moni Shoua
[not found] ` <4C18F21D.3050502-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
2010-06-16 15:54 ` Steve Wise
[not found] ` <4C18F39D.3040609-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-06-16 15:59 ` Tung, Chien Tin
2010-06-16 17:02 ` Jason Gunthorpe
[not found] ` <20100616170234.GA2932-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-06-16 17:12 ` Steve Wise
[not found] ` <4C1905E6.2000304-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-06-16 17:52 ` Jason Gunthorpe
[not found] ` <20100616175259.GF4630-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2010-06-16 18:35 ` Steve Wise
[not found] ` <4C19195B.1080003-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2010-06-17 13:58 ` Doug Ledford
2010-06-17 14:10 ` Doug Ledford
2010-06-16 14:53 ` [ewg] " Moni Shoua
[not found] ` <4C18E557.5050804-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org>
2010-06-23 17:31 ` Roland Dreier [this message]
[not found] ` <ada4ogtvenr.fsf-BjVyx320WGW9gfZ95n9DRSW4+XlvGpQz@public.gmane.org>
2010-06-24 19:44 ` Moni Shoua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada4ogtvenr.fsf@roland-alpha.cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org \
--cc=eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=ewg-G2znmakfqn7U1rindQTSdQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=monis-hKgKHo2Ms0F+cjeuK/JdrQ@public.gmane.org \
--cc=tziporet-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
--cc=yiftahs-smomgflXvOZWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.