All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Julia Lawall <julia@diku.dk>
Cc: rolandd@cisco.com, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, general@lists.openfabrics.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	hnguyen@de.ibm.com, raisch@de.ibm.com
Subject: Re: [PATCH 1/7] drivers/infiniband: Release mutex in error handling code
Date: Mon, 21 Jul 2008 16:25:07 +0000	[thread overview]
Message-ID: <ada4p6j6w7w.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0807210956040.24625@ask.diku.dk> (Julia Lawall's message of "Mon, 21 Jul 2008 09:57:04 +0200 (CEST)")

 > --- a/drivers/infiniband/hw/ehca/ipz_pt_fn.c
 > +++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.c
 > @@ -163,6 +163,7 @@ static int alloc_small_queue_page(struct
 >  
 >  out:
 >  	ehca_err(pd->ib_pd.device, "failed to allocate small queue page");
 > +	mutex_unlock(&pd->lock);
 >  	return 0;
 >  }

Thanks, looks obviously correct.  ehca guys, I will queue this for my
next pull request to Linus; please let me know if you see a problem and
want me to drop it.

 - R.

WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Julia Lawall <julia@diku.dk>
Cc: rolandd@cisco.com, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, general@lists.openfabrics.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	hnguyen@de.ibm.com, raisch@de.ibm.com
Subject: Re: [PATCH 1/7] drivers/infiniband: Release mutex in error handling code
Date: Mon, 21 Jul 2008 09:25:07 -0700	[thread overview]
Message-ID: <ada4p6j6w7w.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0807210956040.24625@ask.diku.dk> (Julia Lawall's message of "Mon, 21 Jul 2008 09:57:04 +0200 (CEST)")

 > --- a/drivers/infiniband/hw/ehca/ipz_pt_fn.c
 > +++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.c
 > @@ -163,6 +163,7 @@ static int alloc_small_queue_page(struct
 >  
 >  out:
 >  	ehca_err(pd->ib_pd.device, "failed to allocate small queue page");
 > +	mutex_unlock(&pd->lock);
 >  	return 0;
 >  }

Thanks, looks obviously correct.  ehca guys, I will queue this for my
next pull request to Linus; please let me know if you see a problem and
want me to drop it.

 - R.

  reply	other threads:[~2008-07-21 16:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-21  7:57 [PATCH 1/7] drivers/infiniband: Release mutex in error handling code Julia Lawall
2008-07-21  7:57 ` Julia Lawall
2008-07-21 16:25 ` Roland Dreier [this message]
2008-07-21 16:25   ` Roland Dreier
2008-07-21 18:28 ` Hoang-Nam Nguyen
2008-07-21 18:28   ` Hoang-Nam Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada4p6j6w7w.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=general@lists.openfabrics.org \
    --cc=hal.rosenstock@gmail.com \
    --cc=hnguyen@de.ibm.com \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raisch@de.ibm.com \
    --cc=rolandd@cisco.com \
    --cc=sean.hefty@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.