From: Roland Dreier <rdreier@cisco.com>
To: Julia Lawall <julia@diku.dk>
Cc: rolandd@cisco.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, general@lists.openfabrics.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/11] drivers/infiniband: Move a dereference below a NULL test
Date: Wed, 17 Dec 2008 07:02:52 +0000 [thread overview]
Message-ID: <ada7i5z1dyb.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812161611540.20444@pc-004.diku.dk> (Julia Lawall's message of "Tue, 16 Dec 2008 16:12:16 +0100 (CET)")
> --- a/drivers/infiniband/hw/nes/nes_cm.c
> +++ b/drivers/infiniband/hw/nes/nes_cm.c
> @@ -376,13 +376,14 @@ int schedule_nes_timer(struct nes_cm_node *cm_node, struct sk_buff *skb,
> int close_when_complete)
> {
> unsigned long flags;
> - struct nes_cm_core *cm_core = cm_node->cm_core;
> + struct nes_cm_core *cm_core;
> struct nes_timer_entry *new_send;
> int ret = 0;
> u32 was_timer_set;
>
> if (!cm_node)
> return -EINVAL;
> + cm_core = cm_node->cm_core;
Thanks... I believe this is already taken care of by a patch pending for
2.6.29 (which should be in -next) that removes the test for NULL.
- R.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Julia Lawall <julia@diku.dk>
Cc: rolandd@cisco.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, general@lists.openfabrics.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/11] drivers/infiniband: Move a dereference below a NULL test
Date: Tue, 16 Dec 2008 23:02:52 -0800 [thread overview]
Message-ID: <ada7i5z1dyb.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812161611540.20444@pc-004.diku.dk> (Julia Lawall's message of "Tue, 16 Dec 2008 16:12:16 +0100 (CET)")
> --- a/drivers/infiniband/hw/nes/nes_cm.c
> +++ b/drivers/infiniband/hw/nes/nes_cm.c
> @@ -376,13 +376,14 @@ int schedule_nes_timer(struct nes_cm_node *cm_node, struct sk_buff *skb,
> int close_when_complete)
> {
> unsigned long flags;
> - struct nes_cm_core *cm_core = cm_node->cm_core;
> + struct nes_cm_core *cm_core;
> struct nes_timer_entry *new_send;
> int ret = 0;
> u32 was_timer_set;
>
> if (!cm_node)
> return -EINVAL;
> + cm_core = cm_node->cm_core;
Thanks... I believe this is already taken care of by a patch pending for
2.6.29 (which should be in -next) that removes the test for NULL.
- R.
next prev parent reply other threads:[~2008-12-17 7:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 15:12 [PATCH 2/11] drivers/infiniband: Move a dereference below a NULL Julia Lawall
2008-12-16 15:12 ` [PATCH 2/11] drivers/infiniband: Move a dereference below a NULL test Julia Lawall
2008-12-17 7:02 ` Roland Dreier [this message]
2008-12-17 7:02 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada7i5z1dyb.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=general@lists.openfabrics.org \
--cc=hal.rosenstock@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.