All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@osdl.org, wli@holomorphy.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Terminate hugetlbfs mount argument list
Date: Tue, 11 Mar 2008 16:26:00 -0700	[thread overview]
Message-ID: <ada7ig8lu5z.fsf@cisco.com> (raw)
In-Reply-To: <20080311225623.GE428@one.firstfloor.org> (Andi Kleen's message of "Tue, 11 Mar 2008 23:56:23 +0100")

 > Hmm indeed I did. To my defense it's a weird unusual coding pattern
 > that tricked me.  What good is it to give terminator elements own enum values?

It's a little odd.  But I guess it does let you do

	token = match_token(...table...);
	switch (token) {
	case ERR_VALUE:...

and get ERR_VALUE back for anything that doesn't match one of the real
token patterns.

 - R.

      reply	other threads:[~2008-03-11 23:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 22:42 [PATCH] Terminate hugetlbfs mount argument list Andi Kleen
2008-03-11 22:48 ` Roland Dreier
2008-03-11 22:56   ` Andi Kleen
2008-03-11 23:26     ` Roland Dreier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ada7ig8lu5z.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=akpm@osdl.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.