All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: akpm@osdl.org, wli@holomorphy.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Terminate hugetlbfs mount argument list
Date: Tue, 11 Mar 2008 15:48:46 -0700	[thread overview]
Message-ID: <adabq5klvw1.fsf@cisco.com> (raw)
In-Reply-To: <20080311224204.GA16719@basil.nowhere.org> (Andi Kleen's message of "Tue, 11 Mar 2008 23:42:04 +0100")

 > The match_table_t for the mount arguments in hugetlbfs wasn't 
 > terminated as match_tokens expect. I didn't see a crash just code
 > audit, but it's still safer to terminate it in case the variables after
 > that in .data are not NULL.

I think you're misunderstanding the match_token() interface.  The
comment before match_token() says:

 * @table: match_table_t describing the set of allowed option tokens and the
 * arguments that may be associated with them. Must be terminated with a
 * &struct match_token whose pattern is set to the NULL pointer.

and that's exactly what already exists here:

 	{Opt_gid,	"gid=%u"},
 	{Opt_err,	NULL},

So your patch is effectively an obfuscated NOP.

 - R.

  reply	other threads:[~2008-03-11 22:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11 22:42 [PATCH] Terminate hugetlbfs mount argument list Andi Kleen
2008-03-11 22:48 ` Roland Dreier [this message]
2008-03-11 22:56   ` Andi Kleen
2008-03-11 23:26     ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adabq5klvw1.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=akpm@osdl.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.