From: Roland Dreier <rdreier@cisco.com>
To: Scott Feldman <scofeldm@cisco.com>
Cc: James.Bottomley@HansenPartnership.com, davem@davemloft.net,
michaelc@cs.wisc.edu, gospo@redhat.com, abjoglek@cisco.com,
jeykholt@cisco.com, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Consolidate shared code between enic and fnic drivers.
Date: Tue, 23 Jun 2009 13:58:10 -0700 [thread overview]
Message-ID: <ada8wjipt0d.fsf@cisco.com> (raw)
In-Reply-To: <20090618050502.30610.69142.stgit@palito_client100.nuovasystems.com> (Scott Feldman's message of "Wed, 17 Jun 2009 22:05:04 -0700")
> The Cisco enic 10G Ethernet driver and the fnic FCoE HBA driver share
> much of the same hardware-access code because enic and fnic devices are
> really two functions on a converged-I/O PCIe device. This patch
> consolidates the shared code into one shared module, thus eliminating
> the code duplication. No functional changes are made by the patch.
Big ACK on this from me -- I never liked duplicating all this code
between the two drivers.
- R.
prev parent reply other threads:[~2009-06-23 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-18 5:05 [PATCH] Consolidate shared code between enic and fnic drivers Scott Feldman
2009-06-18 9:29 ` Hannes Reinecke
2009-06-18 17:03 ` Mike Christie
2009-06-18 17:19 ` Scott Feldman
2009-06-18 17:19 ` Scott Feldman
2009-06-18 17:45 ` Mike Christie
2009-06-23 21:03 ` Roland Dreier
2009-06-23 23:53 ` Joe Eykholt
2009-06-25 16:38 ` Roland Dreier
2009-06-23 21:02 ` Roland Dreier
2009-06-18 14:03 ` Ben Hutchings
2009-06-23 20:58 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada8wjipt0d.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=abjoglek@cisco.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeykholt@cisco.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.