All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix CONFIG_COMPAT_BRK help text
@ 2008-02-07 22:09 Roland Dreier
  2008-02-07 22:20 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Roland Dreier @ 2008-02-07 22:09 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: linux-kernel

CONFIG_COMPAT_BRK=y means that heap randomization is turned off, so
it's *always* a safe choice.  I assume the help text is trying to say
that if one does not run ancient binaries, then enabling heap
randomization is safe.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
diff --git a/init/Kconfig b/init/Kconfig
index 95ac265..242ce32 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -565,7 +565,7 @@ config COMPAT_BRK
 	  disabled, and can be overriden runtime by setting
 	  /proc/sys/kernel/randomize_va_space to 2.
 
-	  On non-ancient distros (post-2000 ones) Y is usually a safe choice.
+	  On non-ancient distros (post-2000 ones) N is usually a safe choice.
 
 config BASE_FULL
 	default y

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix CONFIG_COMPAT_BRK help text
  2008-02-07 22:09 [PATCH] Fix CONFIG_COMPAT_BRK help text Roland Dreier
@ 2008-02-07 22:20 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-02-07 22:20 UTC (permalink / raw)
  To: Roland Dreier; +Cc: linux-kernel


* Roland Dreier <rdreier@cisco.com> wrote:

> CONFIG_COMPAT_BRK=y means that heap randomization is turned off, so 
> it's *always* a safe choice.  I assume the help text is trying to say 
> that if one does not run ancient binaries, then enabling heap 
> randomization is safe.

> -	  On non-ancient distros (post-2000 ones) Y is usually a safe choice.
> +	  On non-ancient distros (post-2000 ones) N is usually a safe choice.

yeah - this typo fix is already in x86.git.

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-07 22:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-07 22:09 [PATCH] Fix CONFIG_COMPAT_BRK help text Roland Dreier
2008-02-07 22:20 ` Ingo Molnar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.