From: Roland Dreier <rdreier@cisco.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
Jeremy Fitzhardinge <jeremy@goop.org>,
the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Greg KH <gregkh@suse.de>, Jens Axboe <jens.axboe@oracle.com>,
Chris Wright <chrisw@redhat.com>,
kurt.hackel@oracle.com, Ky Srinivasan <ksrinivasan@novell.com>,
Beulich <jbeulich@novell.com>, Avi Kivity <avi@redhat.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 17/17] xen: disable MSI
Date: Thu, 28 May 2009 15:21:14 -0700 [thread overview]
Message-ID: <adaab4w6f8l.fsf@cisco.com> (raw)
In-Reply-To: <20090527233807.e7e39e97.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 27 May 2009 23:38:07 -0700")
> Yup. I presently use "Addresses: <url>" in the changelog.
>
> y:/usr/src/git26> git-log | grep '^ Addresses.*bugzilla' | wc -l
> 36
>
> Formalising that a bit more would be good.
>
> Not all patches literally "close" a bugzilla report though. Sometimes
> there's related info in bugzilla but the bug remains. But
> "closes-bug:" is close enough.
Yes, I deliberately didn't suggest "Fixes-bug:" but I like your
"Addresses:" language even better. I'll start using that for any
commits from now on.
- R.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Chris Wright <chrisw@redhat.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Xen-devel <xen-devel@lists.xensource.com>,
Ky Srinivasan <ksrinivasan@novell.com>,
kurt.hackel@oracle.com, the arch/x86 maintainers <x86@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
Avi Kivity <avi@redhat.com>, Jens Axboe <jens.axboe@oracle.com>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <gregkh@suse.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 17/17] xen: disable MSI
Date: Thu, 28 May 2009 15:21:14 -0700 [thread overview]
Message-ID: <adaab4w6f8l.fsf@cisco.com> (raw)
In-Reply-To: <20090527233807.e7e39e97.akpm@linux-foundation.org> (Andrew Morton's message of "Wed, 27 May 2009 23:38:07 -0700")
> Yup. I presently use "Addresses: <url>" in the changelog.
>
> y:/usr/src/git26> git-log | grep '^ Addresses.*bugzilla' | wc -l
> 36
>
> Formalising that a bit more would be good.
>
> Not all patches literally "close" a bugzilla report though. Sometimes
> there's related info in bugzilla but the bug remains. But
> "closes-bug:" is close enough.
Yes, I deliberately didn't suggest "Fixes-bug:" but I like your
"Addresses:" language even better. I'll start using that for any
commits from now on.
- R.
next prev parent reply other threads:[~2009-05-28 22:21 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-27 7:37 [GIT PULL REPOST] xen/dom0/apic-ops: Xen dom0 APIC changes Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 01/17] xen/dom0: handle acpi lapic parsing in Xen dom0 Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-06-02 16:58 ` Thomas Gleixner
2009-06-03 6:38 ` Jeremy Fitzhardinge
2009-06-03 6:38 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 02/17] x86: add io_apic_ops to allow interception Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 03/17] xen: implement io_apic_ops Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 04/17] xen: create dummy ioapic mapping Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 05/17] xen: implement pirq type event channels Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 06/17] x86/io_apic: add get_nr_irqs_gsi() Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 07/17] xen/apic: identity map gsi->irqs Jeremy Fitzhardinge
2009-05-27 7:37 ` Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 08/17] xen: direct irq registration to pirq event channels Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 09/17] xen: bind pirq to vector and event channel Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 10/17] xen: pre-initialize legacy irqs early Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 11/17] xen: don't setup acpi interrupt unless there is one Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 12/17] xen: use acpi_get_override_irq() to get triggering for legacy irqs Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 13/17] xen: initialize irq 0 too Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 14/17] xen: dynamically allocate irq & event structures Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 15/17] xen: set pirq name to something useful Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 16/17] xen: fix legacy irq setup, make ioapic-less machines work Jeremy Fitzhardinge
2009-05-27 7:37 ` [PATCH 17/17] xen: disable MSI Jeremy Fitzhardinge
2009-05-27 15:34 ` Linus Torvalds
2009-05-27 20:40 ` David Miller
2009-05-27 22:25 ` Ingo Molnar
2009-05-27 22:25 ` Ingo Molnar
2009-05-27 21:18 ` Ingo Molnar
2009-05-27 21:18 ` Ingo Molnar
2009-05-27 21:46 ` Linus Torvalds
2009-05-27 22:01 ` Ingo Molnar
2009-05-27 22:01 ` Ingo Molnar
2009-05-27 22:03 ` Roland Dreier
2009-05-27 22:13 ` Linus Torvalds
2009-05-27 22:20 ` Roland Dreier
2009-05-27 22:26 ` Ingo Molnar
2009-05-27 22:26 ` Ingo Molnar
2009-05-28 6:28 ` Alan Cox
2009-05-28 6:28 ` Alan Cox
2009-05-28 6:38 ` Andrew Morton
2009-05-28 22:21 ` Roland Dreier [this message]
2009-05-28 22:21 ` Roland Dreier
2009-06-01 2:09 ` Jon Masters
2009-05-28 19:51 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2009-05-12 23:25 [GIT PULL] Xen APIC hooks (with io_apic_ops) Jeremy Fitzhardinge
2009-05-12 23:25 ` [PATCH 17/17] xen: disable MSI Jeremy Fitzhardinge
2009-03-13 16:42 [GIT PULL] Xen dom0 apic changes Jeremy Fitzhardinge
2009-03-13 16:42 ` [PATCH 17/17] xen: disable MSI Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adaab4w6f8l.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=avi@redhat.com \
--cc=chrisw@redhat.com \
--cc=gregkh@suse.de \
--cc=jbeulich@novell.com \
--cc=jens.axboe@oracle.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=ksrinivasan@novell.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.