From: Roland Dreier <rdreier@cisco.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joel Becker <Joel.Becker@oracle.com>,
Mark Fasheh <mfasheh@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [GIT PULL] ocfs2 changes for 2.6.32
Date: Thu, 17 Sep 2009 11:40:33 -0700 [thread overview]
Message-ID: <adabpl9ct3y.fsf@cisco.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0909170856050.4950@localhost.localdomain> (Linus Torvalds's message of "Thu, 17 Sep 2009 09:29:14 -0700 (PDT)")
> int copy_file(const char *src, const char *dst)
> {
> /* Start a file copy */
> int cookie = copyfile(src, dst, 0);
>
> /* Async case? */
> if (cookie > 0) {
> int ret;
>
> while ((ret = copyfile_ctrl(cookie, COPYFILE_WAIT)) > 0)
> /* nothing */;
>
> /* Error handling is shared for async/sync */
> cookie = ret;
> }
> if (cookie < 0) {
> perror("copyfile failed");
> return -1;
> }
I guess one bit of semantics to figure out is what happens if copyfile()
does the async case but then copyfile_ctrl() returns an error halfway
through... is the state of the dest file just undefined?
- R.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joel Becker <Joel.Becker@oracle.com>,
Mark Fasheh <mfasheh@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ocfs2-devel@oss.oracle.com
Subject: Re: [GIT PULL] ocfs2 changes for 2.6.32
Date: Thu, 17 Sep 2009 11:40:33 -0700 [thread overview]
Message-ID: <adabpl9ct3y.fsf@cisco.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0909170856050.4950@localhost.localdomain> (Linus Torvalds's message of "Thu, 17 Sep 2009 09:29:14 -0700 (PDT)")
> int copy_file(const char *src, const char *dst)
> {
> /* Start a file copy */
> int cookie = copyfile(src, dst, 0);
>
> /* Async case? */
> if (cookie > 0) {
> int ret;
>
> while ((ret = copyfile_ctrl(cookie, COPYFILE_WAIT)) > 0)
> /* nothing */;
>
> /* Error handling is shared for async/sync */
> cookie = ret;
> }
> if (cookie < 0) {
> perror("copyfile failed");
> return -1;
> }
I guess one bit of semantics to figure out is what happens if copyfile()
does the async case but then copyfile_ctrl() returns an error halfway
through... is the state of the dest file just undefined?
- R.
next prev parent reply other threads:[~2009-09-17 18:40 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 20:04 [Ocfs2-devel] [GIT PULL] ocfs2 changes for 2.6.32 Joel Becker
2009-09-11 20:04 ` Joel Becker
2009-09-14 21:32 ` [Ocfs2-devel] " Linus Torvalds
2009-09-14 21:32 ` Linus Torvalds
2009-09-14 22:14 ` [Ocfs2-devel] " Joel Becker
2009-09-14 22:14 ` Joel Becker
2009-09-14 23:27 ` [Ocfs2-devel] " Linus Torvalds
2009-09-14 23:27 ` Linus Torvalds
2009-09-15 0:04 ` [Ocfs2-devel] " Joel Becker
2009-09-15 0:04 ` Joel Becker
2009-09-15 0:31 ` [Ocfs2-devel] " Linus Torvalds
2009-09-15 0:31 ` Linus Torvalds
2009-09-15 0:54 ` [Ocfs2-devel] " Joel Becker
2009-09-15 0:54 ` Joel Becker
2009-09-15 2:01 ` [Ocfs2-devel] " Linus Torvalds
2009-09-15 2:01 ` Linus Torvalds
2009-09-15 4:05 ` [Ocfs2-devel] " Arjan van de Ven
2009-09-15 4:05 ` Arjan van de Ven
2009-09-15 4:35 ` [Ocfs2-devel] " Joel Becker
2009-09-15 4:35 ` Joel Becker
2009-09-15 4:06 ` [Ocfs2-devel] " Joel Becker
2009-09-15 4:06 ` Joel Becker
2009-09-15 16:30 ` [Ocfs2-devel] " Linus Torvalds
2009-09-15 16:30 ` Linus Torvalds
2009-09-15 21:45 ` [Ocfs2-devel] " Joel Becker
2009-09-15 21:45 ` Joel Becker
2009-09-16 4:20 ` [Ocfs2-devel] " Linus Torvalds
2009-09-16 4:20 ` Linus Torvalds
2009-09-16 4:40 ` [Ocfs2-devel] " Joel Becker
2009-09-16 4:40 ` Joel Becker
2009-09-17 16:29 ` [Ocfs2-devel] " Linus Torvalds
2009-09-17 16:29 ` Linus Torvalds
2009-09-17 16:38 ` [Ocfs2-devel] " Arjan van de Ven
2009-09-17 16:38 ` Arjan van de Ven
2009-09-17 20:16 ` [Ocfs2-devel] " Linus Torvalds
2009-09-17 20:16 ` Linus Torvalds
2009-09-17 18:40 ` Roland Dreier [this message]
2009-09-17 18:40 ` Roland Dreier
2009-09-17 20:17 ` [Ocfs2-devel] " Linus Torvalds
2009-09-17 20:17 ` Linus Torvalds
2009-09-17 20:34 ` [Ocfs2-devel] " Joel Becker
2009-09-17 20:34 ` Joel Becker
2009-09-18 0:29 ` [Ocfs2-devel] " Linus Torvalds
2009-09-18 0:29 ` Linus Torvalds
2009-09-17 20:42 ` [Ocfs2-devel] " Roland Dreier
2009-09-17 20:42 ` Roland Dreier
2009-09-17 20:55 ` [Ocfs2-devel] " Linus Torvalds
2009-09-17 20:55 ` Linus Torvalds
2009-09-18 1:43 ` [Ocfs2-devel] " Joel Becker
2009-09-18 1:43 ` Joel Becker
2009-09-18 13:34 ` Pádraig Brady
2009-09-18 13:34 ` Pádraig Brady
2009-09-18 18:37 ` Joel Becker
2009-09-18 18:37 ` Joel Becker
2009-09-18 17:23 ` Peter W. Morreale
2009-09-18 17:23 ` Peter W. Morreale
2009-09-18 18:39 ` Joel Becker
2009-09-18 18:39 ` Joel Becker
2009-09-15 6:44 ` Miklos Szeredi
2009-09-15 6:44 ` Miklos Szeredi
2009-09-23 11:02 ` [Ocfs2-devel] [GIT PULL] ocfs2 changes for 2.6.32 (take 2, no syscall) Joel Becker
2009-09-23 11:02 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adabpl9ct3y.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=Joel.Becker@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.