From: Roland Dreier <rdreier@cisco.com>
To: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, fenkes@de.ibm.com,
stefan.roscher@de.ibm.com, linux-kernel@vger.kernel.org,
openib-general@openib.org
Subject: Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs
Date: Fri, 20 Jul 2007 21:07:13 -0700 [thread overview]
Message-ID: <adabqe67632.fsf@cisco.com> (raw)
In-Reply-To: <200707201601.52277.hnguyen@linux.vnet.ibm.com> (Hoang-Nam Nguyen's message of "Fri, 20 Jul 2007 16:01:51 +0200")
I applied this, but I agree with checkpatch.pl:
> WARNING: externs should be avoided in .c files
> #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67:
> +extern int ehca_mr_largepage;
>
> WARNING: externs should be avoided in .c files
> #949: FILE: drivers/infiniband/hw/ehca/hcp_if.c:753:
> + extern int ehca_debug_level;
if you need to use a variable in more than one .c file, put the extern
declaration in a common header that's included everywhere you use the
variable, including the .c file that it is defined in. That way the
compiler can see if you get confused about the type of the variable.
When you get a chance, please post a follow-on patch to fix this.
- R.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Hoang-Nam Nguyen <hnguyen@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
openib-general@openib.org, fenkes@de.ibm.com,
stefan.roscher@de.ibm.com
Subject: Re: [ofa-general] [PATCH 1/5] ehca: Supports large page MRs
Date: Fri, 20 Jul 2007 21:07:13 -0700 [thread overview]
Message-ID: <adabqe67632.fsf@cisco.com> (raw)
In-Reply-To: <200707201601.52277.hnguyen@linux.vnet.ibm.com> (Hoang-Nam Nguyen's message of "Fri, 20 Jul 2007 16:01:51 +0200")
I applied this, but I agree with checkpatch.pl:
> WARNING: externs should be avoided in .c files
> #227: FILE: drivers/infiniband/hw/ehca/ehca_mrmw.c:67:
> +extern int ehca_mr_largepage;
>
> WARNING: externs should be avoided in .c files
> #949: FILE: drivers/infiniband/hw/ehca/hcp_if.c:753:
> + extern int ehca_debug_level;
if you need to use a variable in more than one .c file, put the extern
declaration in a common header that's included everywhere you use the
variable, including the .c file that it is defined in. That way the
compiler can see if you get confused about the type of the variable.
When you get a chance, please post a follow-on patch to fix this.
- R.
next prev parent reply other threads:[~2007-07-21 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 14:01 [PATCH 1/5] ehca: Supports large page MRs Hoang-Nam Nguyen
2007-07-20 14:01 ` Hoang-Nam Nguyen
2007-07-21 4:07 ` Roland Dreier [this message]
2007-07-21 4:07 ` [ofa-general] " Roland Dreier
2007-07-21 8:22 ` Hoang-Nam Nguyen
2007-07-21 8:22 ` Hoang-Nam Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adabqe67632.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=fenkes@de.ibm.com \
--cc=hnguyen@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=stefan.roscher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.