From: Roland Dreier <rdreier@cisco.com>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Jeff Garzik <jgarzik@pobox.com>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Ben Greear <greearb@candelatech.com>,
Daniel Lezcano <dlezcano@fr.ibm.com>,
Dmitry Mishin <dim@openvz.org>,
Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH] net: Add etun driver
Date: Fri, 06 Apr 2007 13:57:25 -0700 [thread overview]
Message-ID: <adak5wp6x1m.fsf@cisco.com> (raw)
In-Reply-To: <m1abxl5j4s.fsf@ebiederm.dsl.xmission.com> (Eric W. Biederman's message of "Fri, 06 Apr 2007 14:43:15 -0600")
> +/*
> + * The higher levels take care of making this non-reentrant (it's
> + * called with bh's disabled).
> + */
> +static int etun_xmit(struct sk_buff *skb, struct net_device *tx_dev)
You have this comment, but then...
> + dev->features = NETIF_F_FRAGLIST
> + | NETIF_F_HIGHDMA
> + | NETIF_F_LLTX;
you set LLTX, which means that the upper layers _don't_ make sure that
your xmit routine is not reentrant.
It looks like the impact of multiple simultaneous xmit calls is just
the possibility of screwing up the statistics, but still I think you
want to drop the LLTX feature (since you have no lock of your own to
try and take).
next prev parent reply other threads:[~2007-04-06 20:57 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 20:43 [PATCH] net: Add etun driver Eric W. Biederman
2007-04-06 20:34 ` Stephen Hemminger
2007-04-06 21:38 ` Ben Greear
2007-04-06 20:54 ` Stephen Hemminger
2007-04-06 22:01 ` Ben Greear
2007-04-07 2:51 ` Eric W. Biederman
2007-04-09 16:37 ` Johannes Berg
2007-04-09 16:58 ` Patrick McHardy
2007-04-09 18:14 ` Ben Greear
2007-04-09 18:37 ` David Miller
2007-04-09 18:48 ` Ben Greear
2007-04-09 18:45 ` Patrick McHardy
2007-04-09 18:44 ` David Miller
2007-04-09 19:35 ` Eric W. Biederman
2007-04-09 19:48 ` Jeff Garzik
2007-04-09 20:03 ` Johannes Berg
2007-04-09 20:11 ` Patrick McHardy
2007-04-09 20:29 ` Johannes Berg
2007-04-10 0:06 ` Patrick McHardy
2007-04-10 5:47 ` Johannes Berg
2007-04-10 6:08 ` Eric W. Biederman
2007-04-10 6:18 ` Johannes Berg
2007-04-10 7:52 ` Patrick McHardy
2007-04-10 9:18 ` Johannes Berg
2007-04-10 9:52 ` Patrick McHardy
2007-04-10 10:27 ` Johannes Berg
2007-04-10 10:46 ` Patrick McHardy
2007-04-10 11:02 ` Johannes Berg
2007-04-10 11:09 ` Patrick McHardy
2007-04-10 11:16 ` Jeff Garzik
2007-04-10 11:24 ` Johannes Berg
2007-04-10 12:05 ` Patrick McHardy
2007-04-10 13:44 ` John W. Linville
2007-04-10 13:48 ` Johannes Berg
2007-04-10 21:16 ` Johannes Berg
2007-04-11 16:15 ` Patrick McHardy
2007-04-11 16:43 ` Johannes Berg
2007-04-11 16:52 ` Patrick McHardy
2007-04-11 16:59 ` Johannes Berg
2007-04-11 16:16 ` Stephen Hemminger
2007-04-06 20:57 ` Roland Dreier [this message]
2007-04-07 2:08 ` Eric W. Biederman
2007-04-06 21:20 ` Ben Greear
2007-04-07 2:06 ` Eric W. Biederman
2007-04-07 3:31 ` Ben Greear
2007-04-07 5:37 ` Eric W. Biederman
2007-04-07 7:31 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adak5wp6x1m.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=dim@openvz.org \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=greearb@candelatech.com \
--cc=jgarzik@pobox.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.