From: Roland Dreier <rdreier@cisco.com>
To: Julia Lawall <julia@diku.dk>
Cc: rolandd@cisco.com, mshefty@ichips.intel.com, halr@voltaire.com,
openib-general@openib.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers/infiniband: Drop redundant includes of moduleparam.h
Date: Wed, 14 Nov 2007 20:54:52 +0000 [thread overview]
Message-ID: <adalk90zgwz.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711132234110.18337@ask.diku.dk> (Julia Lawall's message of "Tue, 13 Nov 2007 22:35:14 +0100 (CET)")
> Drop #include <linux/moduleparam.h> in files that also include #include
> <linux/module.h>. module.h includes moduleparam.h already.
Do we want to make this sort of source code change? I thought that
the consensus about the kernel was that we wanted to avoid relying of
implicit includes of <Y.h> by <X.h> -- in this case a better change
would actually seem to be to explicitly include moduleparam.h in files
using module parameters and then remove the include from module.h.
- R.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Julia Lawall <julia@diku.dk>
Cc: rolandd@cisco.com, mshefty@ichips.intel.com, halr@voltaire.com,
openib-general@openib.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/4] drivers/infiniband: Drop redundant includes of moduleparam.h
Date: Wed, 14 Nov 2007 12:54:52 -0800 [thread overview]
Message-ID: <adalk90zgwz.fsf@cisco.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0711132234110.18337@ask.diku.dk> (Julia Lawall's message of "Tue, 13 Nov 2007 22:35:14 +0100 (CET)")
> Drop #include <linux/moduleparam.h> in files that also include #include
> <linux/module.h>. module.h includes moduleparam.h already.
Do we want to make this sort of source code change? I thought that
the consensus about the kernel was that we wanted to avoid relying of
implicit includes of <Y.h> by <X.h> -- in this case a better change
would actually seem to be to explicitly include moduleparam.h in files
using module parameters and then remove the include from module.h.
- R.
next prev parent reply other threads:[~2007-11-14 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 21:35 [PATCH 3/4] drivers/infiniband: Drop redundant includes of moduleparam.h Julia Lawall
2007-11-13 21:35 ` Julia Lawall
2007-11-14 20:54 ` Roland Dreier [this message]
2007-11-14 20:54 ` Roland Dreier
2007-11-14 21:00 ` [PATCH 3/4] drivers/infiniband: Drop redundant includes of Randy Dunlap
2007-11-14 21:00 ` [PATCH 3/4] drivers/infiniband: Drop redundant includes of moduleparam.h Randy Dunlap
2007-11-14 21:18 ` [PATCH 3/4] drivers/infiniband: Drop redundant includes of Julia Lawall
2007-11-14 21:18 ` [PATCH 3/4] drivers/infiniband: Drop redundant includes of moduleparam.h Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adalk90zgwz.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=halr@voltaire.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshefty@ichips.intel.com \
--cc=openib-general@openib.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.