* [PATCH] Add MODULE_DEVICE_TABLE() so ioatdma module is autoloaded
@ 2009-07-01 18:05 Roland Dreier
2009-07-02 0:26 ` Dan Williams
0 siblings, 1 reply; 2+ messages in thread
From: Roland Dreier @ 2009-07-01 18:05 UTC (permalink / raw)
To: dan.j.williams, maciej.sosnowski; +Cc: linux-kernel
The ioatdma module is missing aliases for the PCI devices it supports,
so it is not autoloaded on boot. Add a MODULE_DEVICE_TABLE() to get
these aliases.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
Not sure if not autoloading was intentional or if it's just an
oversight, but this patch seems useful to me, so please apply if it
makes sense to you.
drivers/dma/ioat.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/dma/ioat.c b/drivers/dma/ioat.c
index 2225bb6..a1d8b8d 100644
--- a/drivers/dma/ioat.c
+++ b/drivers/dma/ioat.c
@@ -60,6 +60,8 @@ static struct pci_device_id ioat_pci_tbl[] = {
{ 0, }
};
+MODULE_DEVICE_TABLE(pci, ioat_pci_tbl);
+
struct ioat_device {
struct pci_dev *pdev;
void __iomem *iobase;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Add MODULE_DEVICE_TABLE() so ioatdma module is autoloaded
2009-07-01 18:05 [PATCH] Add MODULE_DEVICE_TABLE() so ioatdma module is autoloaded Roland Dreier
@ 2009-07-02 0:26 ` Dan Williams
0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2009-07-02 0:26 UTC (permalink / raw)
To: Roland Dreier; +Cc: maciej.sosnowski, linux-kernel
On Wed, Jul 1, 2009 at 11:05 AM, Roland Dreier<rdreier@cisco.com> wrote:
> The ioatdma module is missing aliases for the PCI devices it supports,
> so it is not autoloaded on boot. Add a MODULE_DEVICE_TABLE() to get
> these aliases.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> Not sure if not autoloading was intentional or if it's just an
> oversight, but this patch seems useful to me, so please apply if it
> makes sense to you.
>
Makes sense. I believe the only hesitation is that it is a bit
awkward to remove (ifdown all interfaces, stop all raid456 arrays).
However, unless Maciej disagrees I think we should go ahead and
autoload it.
Applied for now to the 'fixes' branch of async_tx.git.
Thanks,
Dan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-02 0:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-01 18:05 [PATCH] Add MODULE_DEVICE_TABLE() so ioatdma module is autoloaded Roland Dreier
2009-07-02 0:26 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.