All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-kernel@vger.kernel.org
Subject: Re: [bisected] Latest git not seeing HD with sata_nv
Date: Tue, 22 Apr 2008 18:38:36 -0700	[thread overview]
Message-ID: <adar6cxcpur.fsf@cisco.com> (raw)
In-Reply-To: <adave29cqgh.fsf@cisco.com> (Roland Dreier's message of "Tue, 22 Apr 2008 18:25:34 -0700")

FWIW, the patch below also makes my box start working again...  I have
no idea what the right fix is, given that bug 3352 mostly seems to be
about nforce2 and nforce3, and my box has a more modern nvidia chipset:

    00:04.0 IDE interface [0101]: nVidia Corporation MCP55 IDE [10de:036e] (rev a1)

Anyway, it seems 305d2a1a broke the logic that nv_hardreset() relies on
when it doesn't let sata_sff_hardreset() set class.

diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 109b074..d0d85a3 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -1597,7 +1597,7 @@ static int nv_hardreset(struct ata_link *link, unsigned int *class,
 	 * some controllers.  Don't classify on hardreset.  For more
 	 * info, see http://bugzilla.kernel.org/show_bug.cgi?id=3352
 	 */
-	return sata_sff_hardreset(link, &dummy, deadline);
+	return sata_sff_hardreset(link, class, deadline);
 }
 
 static void nv_adma_error_handler(struct ata_port *ap)

  reply	other threads:[~2008-04-23  1:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-22 23:20 [bisected] Latest git not seeing HD with sata_nv Roland Dreier
2008-04-22 23:47 ` Yinghai Lu
2008-04-23  1:25 ` Roland Dreier
2008-04-23  1:38   ` Roland Dreier [this message]
2008-04-23  1:51     ` Tejun Heo
2008-04-23  1:35 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adar6cxcpur.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.