From: Roland Dreier <rdreier@cisco.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-kernel@vger.kernel.org
Subject: Re: [bisected] Latest git not seeing HD with sata_nv
Date: Tue, 22 Apr 2008 18:25:34 -0700 [thread overview]
Message-ID: <adave29cqgh.fsf@cisco.com> (raw)
In-Reply-To: <adazlrlcw9f.fsf@cisco.com> (Roland Dreier's message of "Tue, 22 Apr 2008 16:20:12 -0700")
> It seems that commit 305d2a1a ("libata: unify mechanism to request
> follow-up SRST") causes sata_nv not to see the HD on a system I have
> here; with current git (80750147), I get this in my bootlog:
I wonder if this is related to the code
static int nv_hardreset(struct ata_link *link, unsigned int *class,
unsigned long deadline)
{
unsigned int dummy;
/* SATA hardreset fails to retrieve proper device signature on
* some controllers. Don't classify on hardreset. For more
* info, see http://bugzilla.kernel.org/show_bug.cgi?id=3352
*/
return sata_sff_hardreset(link, &dummy, deadline);
}
It seems especially suspicious given that 305d2a1a touches
sata_sff_hardreset...
- R.
next prev parent reply other threads:[~2008-04-23 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 23:20 [bisected] Latest git not seeing HD with sata_nv Roland Dreier
2008-04-22 23:47 ` Yinghai Lu
2008-04-23 1:25 ` Roland Dreier [this message]
2008-04-23 1:38 ` Roland Dreier
2008-04-23 1:51 ` Tejun Heo
2008-04-23 1:35 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adave29cqgh.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.