From: Roland Dreier <rdreier@cisco.com>
To: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
Cc: TKLEIN@de.ibm.com, THEMANN@de.ibm.com, fenkes@de.ibm.com,
OF-EWG <ewg@lists.openfabrics.org>,
LKML <linux-kernel@vger.kernel.org>,
LinuxPPC-Dev <linuxppc-dev@ozlabs.org>,
raisch@de.ibm.com, general@lists.openfabrics.org
Subject: Re: [PATCH 2/2] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts
Date: Mon, 09 Jun 2008 09:38:59 -0700 [thread overview]
Message-ID: <adatzg28sws.fsf@cisco.com> (raw)
In-Reply-To: <200806091745.19147.ossrosch@linux.vnet.ibm.com> (Stefan Roscher's message of "Mon, 9 Jun 2008 17:45:17 +0200")
> + if (desc->chip && desc->chip->eoi)
> + desc->chip->eoi(irq);
This doesn't seem like the type of thing a device driver should be
doing. Both patches are rather short on changelog text -- what is the
issue here and how does this fix it?
- R.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
Cc: Roland Dreier <rolandd@cisco.com>,
"OF-EWG" <ewg@lists.openfabrics.org>,
general@lists.openfabrics.org,
LKML <linux-kernel@vger.kernel.org>,
"LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>,
hnguyen@de.ibm.com, fenkes@de.ibm.com, raisch@de.ibm.com,
TKLEIN@de.ibm.com, THEMANN@de.ibm.com
Subject: Re: [PATCH 2/2] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts
Date: Mon, 09 Jun 2008 09:38:59 -0700 [thread overview]
Message-ID: <adatzg28sws.fsf@cisco.com> (raw)
In-Reply-To: <200806091745.19147.ossrosch@linux.vnet.ibm.com> (Stefan Roscher's message of "Mon, 9 Jun 2008 17:45:17 +0200")
> + if (desc->chip && desc->chip->eoi)
> + desc->chip->eoi(irq);
This doesn't seem like the type of thing a device driver should be
doing. Both patches are rather short on changelog text -- what is the
issue here and how does this fix it?
- R.
next prev parent reply other threads:[~2008-06-09 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 15:45 [PATCH 2/2] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts Stefan Roscher
2008-06-09 15:45 ` Stefan Roscher
2008-06-09 16:38 ` Roland Dreier [this message]
2008-06-09 16:38 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adatzg28sws.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=THEMANN@de.ibm.com \
--cc=TKLEIN@de.ibm.com \
--cc=ewg@lists.openfabrics.org \
--cc=fenkes@de.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ossrosch@linux.vnet.ibm.com \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.