All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roland Dreier <rdreier@cisco.com>
To: Aleksey Senin <alekseys@voltaire.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, Linus <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"general@lists.openfabrics.org" <general@lists.openfabrics.org>
Subject: [ofa-general] Re: linux-next: origin tree build failure
Date: Mon, 29 Dec 2008 08:13:36 -0800	[thread overview]
Message-ID: <adavdt3t0wf.fsf@cisco.com> (raw)
In-Reply-To: <1230544737.4261.33.camel@alst60> (Aleksey Senin's message of "Mon, 29 Dec 2008 11:58:57 +0200")

 > After another investigation of this problem, I think that proposed
 > solution is #ifdef as good for a first stage. IPv6 support is mandatory
 > when we are talking about running linux in some organization. But, of
 > course, the way how it implemented in IB stack should be changed. So on
 > the second stage, I'd like drop out these "defines" and at the time of
 > module initialization obtain addresses of IPv6 functions and in the case
 > if they are present at the runtime, call them. It should be nice
 > solution for RMDA_CM and IPoIB modules.

I don't think this second stage sounds like a good idea.  Suppose
someone loads the RDMA CM first, so it doesn't find the ipv6 functions,
and then later loads and configures ipv6.  You'll end up in a situation
where trying to make an IPv6 connection fails spuriously.  (And just the
ugliness of looking up function pointers isn't very nice either)

 - R.

WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Aleksey Senin <alekseys@voltaire.com>
Cc: "general\@lists.openfabrics.org" <general@lists.openfabrics.org>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Linus <torvalds@linux-foundation.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: linux-next: origin tree build failure
Date: Mon, 29 Dec 2008 08:13:36 -0800	[thread overview]
Message-ID: <adavdt3t0wf.fsf@cisco.com> (raw)
In-Reply-To: <1230544737.4261.33.camel@alst60> (Aleksey Senin's message of "Mon, 29 Dec 2008 11:58:57 +0200")

 > After another investigation of this problem, I think that proposed
 > solution is #ifdef as good for a first stage. IPv6 support is mandatory
 > when we are talking about running linux in some organization. But, of
 > course, the way how it implemented in IB stack should be changed. So on
 > the second stage, I'd like drop out these "defines" and at the time of
 > module initialization obtain addresses of IPv6 functions and in the case
 > if they are present at the runtime, call them. It should be nice
 > solution for RMDA_CM and IPoIB modules.

I don't think this second stage sounds like a good idea.  Suppose
someone loads the RDMA CM first, so it doesn't find the ipv6 functions,
and then later loads and configures ipv6.  You'll end up in a situation
where trying to make an IPv6 connection fails spuriously.  (And just the
ugliness of looking up function pointers isn't very nice either)

 - R.

  reply	other threads:[~2008-12-29 16:13 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-29  0:43 linux-next: origin tree build failure Stephen Rothwell
2008-12-29  3:36 ` Roland Dreier
2008-12-29  3:44 ` Roland Dreier
2008-12-29  9:58   ` Aleksey Senin
2008-12-29 16:13     ` Roland Dreier [this message]
2008-12-29 16:13       ` Roland Dreier
2008-12-29 16:52       ` [ofa-general] " Aleksey Senin
2008-12-29 16:52         ` Aleksey Senin
2008-12-29 20:18     ` [ofa-general] " Roland Dreier
2008-12-29 20:18       ` Roland Dreier
2008-12-29 21:07       ` [ofa-general] " Linus Torvalds
2008-12-29 21:07         ` Linus Torvalds
2008-12-29 21:35         ` [ofa-general] " Roland Dreier
2008-12-29 21:35           ` Roland Dreier
2008-12-29 21:48           ` [ofa-general] " Roland Dreier
2008-12-29 21:48             ` Roland Dreier
2008-12-29  8:48 ` Aleksey Senin
2008-12-29  8:48   ` Aleksey Senin
2008-12-30  7:38 ` [ofa-general] " Roland Dreier
2008-12-30  7:38   ` Roland Dreier
2008-12-30  8:30   ` [ofa-general] " Stephen Rothwell
2008-12-30  8:30     ` Stephen Rothwell
2008-12-30 15:41     ` [ofa-general] " Roland Dreier
2008-12-30 15:46       ` Stephen Rothwell
2008-12-30 22:52         ` Stephen Rothwell
2008-12-30 22:52           ` Stephen Rothwell
2008-12-30 22:56           ` Roland Dreier
2008-12-30 23:17             ` Stephen Rothwell
2008-12-30 23:17               ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adavdt3t0wf.fsf@cisco.com \
    --to=rdreier@cisco.com \
    --cc=alekseys@voltaire.com \
    --cc=general@lists.openfabrics.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.