From: Roland Dreier <rdreier@cisco.com>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-next@vger.kernel.org, general@lists.openfabrics.org
Subject: [ofa-general] Re: linux-next: [PATCH] infiniband/hw/ipath/ipath_sdma.c , fix compiler warnings
Date: Fri, 23 May 2008 10:42:24 -0700 [thread overview]
Message-ID: <adave14apdr.fsf@cisco.com> (raw)
In-Reply-To: <48342C6C.2010502@googlemail.com> (Gabriel C.'s message of "Wed, 21 May 2008 16:06:36 +0200")
> drivers/infiniband/hw/ipath/ipath_sdma.c: In function 'sdma_abort_task':
> drivers/infiniband/hw/ipath/ipath_sdma.c:267: warning: passing argument 2 of 'constant_test_bit' from incompatible pointer type
Perhaps the best way to fix these is to change code like
if (/* ScoreBoardDrainInProg */
test_bit(63, &hwstatus) ||
/* AbortInProg */
test_bit(62, &hwstatus) ||
/* InternalSDmaEnable */
test_bit(61, &hwstatus) ||
/* ScbEmpty */
!test_bit(30, &hwstatus)) {
to something like
if ((hwstatus & (IPATH_SDMA_STATUS_SCORE_BOARD_DRAIN_IN_PROG |
IPATH_SDMA_STATUS_ABORT_IN_PROG |
IPATH_SDMA_STATUS_INTERNAL_SDMA_ENABLE)) ||
!(hwstatus & IPATH_SDMA_STATUS_SCB_EMPTY)) {
with appropriate defines for the constants 1ull << 63 etc.
(I think I got the logic correct but someone should check)
> drivers/infiniband/hw/ipath/ipath_sdma.c:348: warning: format '%016llx' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
> drivers/infiniband/hw/ipath/ipath_sdma.c: In function 'ipath_restart_sdma':
> drivers/infiniband/hw/ipath/ipath_sdma.c:618: warning: format '%016llx' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
I have a fix for this pending; will ask Linus to pull today.
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Gabriel C <nix.or.die@googlemail.com>
Cc: rolandd@cisco.com,
Linux Kernel list <linux-kernel@vger.kernel.org>,
general@lists.openfabrics.org, sean.hefty@intel.com,
hal.rosenstock@gmail.com, linux-next@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: linux-next: [PATCH] infiniband/hw/ipath/ipath_sdma.c , fix compiler warnings
Date: Fri, 23 May 2008 10:42:24 -0700 [thread overview]
Message-ID: <adave14apdr.fsf@cisco.com> (raw)
In-Reply-To: <48342C6C.2010502@googlemail.com> (Gabriel C.'s message of "Wed, 21 May 2008 16:06:36 +0200")
> drivers/infiniband/hw/ipath/ipath_sdma.c: In function 'sdma_abort_task':
> drivers/infiniband/hw/ipath/ipath_sdma.c:267: warning: passing argument 2 of 'constant_test_bit' from incompatible pointer type
Perhaps the best way to fix these is to change code like
if (/* ScoreBoardDrainInProg */
test_bit(63, &hwstatus) ||
/* AbortInProg */
test_bit(62, &hwstatus) ||
/* InternalSDmaEnable */
test_bit(61, &hwstatus) ||
/* ScbEmpty */
!test_bit(30, &hwstatus)) {
to something like
if ((hwstatus & (IPATH_SDMA_STATUS_SCORE_BOARD_DRAIN_IN_PROG |
IPATH_SDMA_STATUS_ABORT_IN_PROG |
IPATH_SDMA_STATUS_INTERNAL_SDMA_ENABLE)) ||
!(hwstatus & IPATH_SDMA_STATUS_SCB_EMPTY)) {
with appropriate defines for the constants 1ull << 63 etc.
(I think I got the logic correct but someone should check)
> drivers/infiniband/hw/ipath/ipath_sdma.c:348: warning: format '%016llx' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
> drivers/infiniband/hw/ipath/ipath_sdma.c: In function 'ipath_restart_sdma':
> drivers/infiniband/hw/ipath/ipath_sdma.c:618: warning: format '%016llx' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'
I have a fix for this pending; will ask Linus to pull today.
next prev parent reply other threads:[~2008-05-23 17:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 14:06 linux-next: [PATCH] infiniband/hw/ipath/ipath_sdma.c , fix compiler warnings Gabriel C
2008-05-22 0:17 ` Stephen Rothwell
2008-05-22 1:45 ` [ofa-general] " Gabriel C
2008-05-22 0:23 ` Tony Breeds
2008-05-22 2:39 ` Gabriel C
2008-05-22 2:42 ` [ofa-general] " Gabriel C
2008-05-22 2:42 ` Gabriel C
2008-05-23 17:42 ` Roland Dreier [this message]
2008-05-23 17:42 ` Roland Dreier
2008-05-23 21:45 ` [ofa-general] " Ralph Campbell
2008-05-23 21:45 ` Ralph Campbell
2008-05-26 22:21 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adave14apdr.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=nix.or.die@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.