From: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
To: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files.
Date: Wed, 29 Sep 2010 10:19:32 -0700 [thread overview]
Message-ID: <adawrq431sr.fsf@cisco.com> (raw)
In-Reply-To: <20100929141112.26944.21931.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org> (Steve Wise's message of "Wed, 29 Sep 2010 09:11:12 -0500")
> @@ -182,6 +182,7 @@ static const struct file_operations qp_debugfs_fops = {
> .open = qp_open,
> .release = qp_release,
> .read = debugfs_read,
> + .llseek = default_llseek,
> };
I think this could actually be generic_file_llseek (right, Arnd?).
Also could qp_read() and other read methods be simplified by using
simple_read_from_buffer()? I don't see anything fancy there, seems like
the read methods could become one-liners that way.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Roland Dreier <rdreier@cisco.com>
To: Steve Wise <swise@opengridcomputing.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-rdma@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files.
Date: Wed, 29 Sep 2010 10:19:32 -0700 [thread overview]
Message-ID: <adawrq431sr.fsf@cisco.com> (raw)
In-Reply-To: <20100929141112.26944.21931.stgit@build.ogc.int> (Steve Wise's message of "Wed, 29 Sep 2010 09:11:12 -0500")
> @@ -182,6 +182,7 @@ static const struct file_operations qp_debugfs_fops = {
> .open = qp_open,
> .release = qp_release,
> .read = debugfs_read,
> + .llseek = default_llseek,
> };
I think this could actually be generic_file_llseek (right, Arnd?).
Also could qp_read() and other read methods be simplified by using
simple_read_from_buffer()? I don't see anything fancy there, seems like
the read methods could become one-liners that way.
- R.
next prev parent reply other threads:[~2010-09-29 17:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 14:11 [PATCH] RDMA/cxgb4: Add default_llseek to debugfs files Steve Wise
[not found] ` <20100929141112.26944.21931.stgit-T4OLL4TyM9aNDNWfRnPdfg@public.gmane.org>
2010-09-29 17:19 ` Roland Dreier [this message]
2010-09-29 17:19 ` Roland Dreier
[not found] ` <adawrq431sr.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
2010-09-29 17:27 ` Steve Wise
2010-09-29 17:27 ` Steve Wise
2010-09-29 17:41 ` Roland Dreier
2010-09-29 17:49 ` Steve Wise
2010-09-29 17:50 ` Roland Dreier
2010-09-29 19:17 ` Arnd Bergmann
2010-09-29 19:17 ` Arnd Bergmann
[not found] ` <201009292117.54828.arnd-r2nGTMty4D4@public.gmane.org>
2010-09-29 19:21 ` Roland Dreier
2010-09-29 19:21 ` Roland Dreier
2010-09-29 19:29 ` Arnd Bergmann
2010-09-29 19:40 ` Roland Dreier
2010-09-29 18:52 ` Roland Dreier
2010-09-29 18:52 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adawrq431sr.fsf@cisco.com \
--to=rdreier-fyb4gu1cfyuavxtiumwx3w@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.