* [PATCH nf-next] netfilter: Kconfig: make NF_FLOW_TABLE_INET depend on NF_TABLES_INET @ 2026-03-26 14:42 Fernando Fernandez Mancera 2026-04-10 1:09 ` Pablo Neira Ayuso 0 siblings, 1 reply; 3+ messages in thread From: Fernando Fernandez Mancera @ 2026-03-26 14:42 UTC (permalink / raw) To: netfilter-devel; +Cc: coreteam, phil, fw, pablo, Fernando Fernandez Mancera As it is not possible to create an inet flowtable without a parent table on inet family, it makes sense that Kconfig NF_FLOW_TABLE_INET symbol depends on NF_TABLES_INET. This reduces the kernel image size a bit when compiling the kernel with CONFIG_IPV6=n. Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de> --- net/netfilter/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 6cdc994fdc8a..c50f2ad67b51 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -717,6 +717,7 @@ endif # NF_TABLES config NF_FLOW_TABLE_INET tristate "Netfilter flow table mixed IPv4/IPv6 module" depends on NF_FLOW_TABLE + depends on NF_TABLES_INET help This option adds the flow table mixed IPv4/IPv6 support. -- 2.53.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH nf-next] netfilter: Kconfig: make NF_FLOW_TABLE_INET depend on NF_TABLES_INET 2026-03-26 14:42 [PATCH nf-next] netfilter: Kconfig: make NF_FLOW_TABLE_INET depend on NF_TABLES_INET Fernando Fernandez Mancera @ 2026-04-10 1:09 ` Pablo Neira Ayuso 2026-04-10 8:12 ` Fernando Fernandez Mancera 0 siblings, 1 reply; 3+ messages in thread From: Pablo Neira Ayuso @ 2026-04-10 1:09 UTC (permalink / raw) To: Fernando Fernandez Mancera; +Cc: netfilter-devel, coreteam, phil, fw On Thu, Mar 26, 2026 at 03:42:46PM +0100, Fernando Fernandez Mancera wrote: > As it is not possible to create an inet flowtable without a parent table > on inet family, it makes sense that Kconfig NF_FLOW_TABLE_INET symbol > depends on NF_TABLES_INET. This reduces the kernel image size a bit when > compiling the kernel with CONFIG_IPV6=n. The nf_flow_table_inet.c file also defines ipv4 and ipv6: static struct nf_flowtable_type flowtable_ipv4 = { .family = NFPROTO_IPV4, .init = nf_flow_table_init, .setup = nf_flow_table_offload_setup, .action = nf_flow_rule_route_ipv4, .free = nf_flow_table_free, .hook = nf_flow_offload_ip_hook, .owner = THIS_MODULE, }; static struct nf_flowtable_type flowtable_ipv6 = { .family = NFPROTO_IPV6, .init = nf_flow_table_init, .setup = nf_flow_table_offload_setup, .action = nf_flow_rule_route_ipv6, .free = nf_flow_table_free, .hook = nf_flow_offload_ipv6_hook, .owner = THIS_MODULE, }; The file name is a bit misleading, someone decide to squash ipv4, ipv6 and _inet_ into the same file. > Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de> > --- > net/netfilter/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig > index 6cdc994fdc8a..c50f2ad67b51 100644 > --- a/net/netfilter/Kconfig > +++ b/net/netfilter/Kconfig > @@ -717,6 +717,7 @@ endif # NF_TABLES > config NF_FLOW_TABLE_INET > tristate "Netfilter flow table mixed IPv4/IPv6 module" > depends on NF_FLOW_TABLE > + depends on NF_TABLES_INET > help > This option adds the flow table mixed IPv4/IPv6 support. > > -- > 2.53.0 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH nf-next] netfilter: Kconfig: make NF_FLOW_TABLE_INET depend on NF_TABLES_INET 2026-04-10 1:09 ` Pablo Neira Ayuso @ 2026-04-10 8:12 ` Fernando Fernandez Mancera 0 siblings, 0 replies; 3+ messages in thread From: Fernando Fernandez Mancera @ 2026-04-10 8:12 UTC (permalink / raw) To: Pablo Neira Ayuso; +Cc: netfilter-devel, coreteam, phil, fw On 4/10/26 3:09 AM, Pablo Neira Ayuso wrote: > On Thu, Mar 26, 2026 at 03:42:46PM +0100, Fernando Fernandez Mancera wrote: >> As it is not possible to create an inet flowtable without a parent table >> on inet family, it makes sense that Kconfig NF_FLOW_TABLE_INET symbol >> depends on NF_TABLES_INET. This reduces the kernel image size a bit when >> compiling the kernel with CONFIG_IPV6=n. > > The nf_flow_table_inet.c file also defines ipv4 and ipv6: > > static struct nf_flowtable_type flowtable_ipv4 = { > .family = NFPROTO_IPV4, > .init = nf_flow_table_init, > .setup = nf_flow_table_offload_setup, > .action = nf_flow_rule_route_ipv4, > .free = nf_flow_table_free, > .hook = nf_flow_offload_ip_hook, > .owner = THIS_MODULE, > }; > > static struct nf_flowtable_type flowtable_ipv6 = { > .family = NFPROTO_IPV6, > .init = nf_flow_table_init, > .setup = nf_flow_table_offload_setup, > .action = nf_flow_rule_route_ipv6, > .free = nf_flow_table_free, > .hook = nf_flow_offload_ipv6_hook, > .owner = THIS_MODULE, > }; > > The file name is a bit misleading, someone decide to squash ipv4, ipv6 > and _inet_ into the same file. > I see everything is squashed into the same file and indeed under the same Kconfig. Then we need to throw away this patch. Yes, it is a bit misleading but given it is like this I do not see a benefit into splitting it now into NF_FLOW_TABLE_IPV4, NF_FLOW_TABLE_IPV6 and NF_FLOW_TABLE_INET variants. Thanks Pablo for pointing this out! Fernando. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-10 8:12 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-03-26 14:42 [PATCH nf-next] netfilter: Kconfig: make NF_FLOW_TABLE_INET depend on NF_TABLES_INET Fernando Fernandez Mancera 2026-04-10 1:09 ` Pablo Neira Ayuso 2026-04-10 8:12 ` Fernando Fernandez Mancera
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.