[PATCH] clk: qcom: sc7280: add missing SDCC1 clocks

[PATCH] clk: qcom: sc7280: add missing SDCC1 clocks

[Ajit Singh]

Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks.
Required on platforms where SDCC1 is used for eMMC.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a3cc092196ef63570c8744c3ac88c3c6c67ab44b

Signed-off-by: Ajit Singh <blfizzyy@gmail.com>
---
 drivers/clk/qcom/clock-sc7280.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
index 7b6ed826023..acdaccf7462 100644
--- a/drivers/clk/qcom/clock-sc7280.c
+++ b/drivers/clk/qcom/clock-sc7280.c
@@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
 	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
 	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
 	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
+	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
 };
 
 static int sc7280_enable(struct clk *clk)
-- 
2.50.1 (Apple Git-155)

Re: [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks

[Casey Connolly]

On 26/02/2026 20:32, Ajit Singh wrote:
> Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks.
> Required on platforms where SDCC1 is used for eMMC.
> 
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a3cc092196ef63570c8744c3ac88c3c6c67ab44b
> 
> Signed-off-by: Ajit Singh <blfizzyy@gmail.com>

Reviewed-by: Casey Connolly <casey.connolly@linaro.org>

> ---
>  drivers/clk/qcom/clock-sc7280.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
> index 7b6ed826023..acdaccf7462 100644
> --- a/drivers/clk/qcom/clock-sc7280.c
> +++ b/drivers/clk/qcom/clock-sc7280.c
> @@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
>  	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
>  };
>  
>  static int sc7280_enable(struct clk *clk)

-- 
// Casey (she/her)

Re: [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks

[Ajit Singh]

Hi, Gentle ping on this patch.
It already has a Reviewed-by from Casey, so I wanted to check whether it can be picked up.

Thanks,
Ajit

> On Fri, Feb 27, 2026 at 05:13:26PM +0530, Casey Connolly wrote:
> Reviewed-by: Casey Connolly <casey.connolly@linaro.org>

Re: [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks

[Sumit Garg]

On Fri, Feb 27, 2026 at 01:02:17AM +0530, Ajit Singh wrote:
> Add GCC_SDCC1_AHB_CLK and GCC_SDCC1_APPS_CLK gate clocks.
> Required on platforms where SDCC1 is used for eMMC.
> 
> Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=a3cc092196ef63570c8744c3ac88c3c6c67ab44b
> 
> Signed-off-by: Ajit Singh <blfizzyy@gmail.com>
> ---
>  drivers/clk/qcom/clock-sc7280.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>

-Sumit

> 
> diff --git a/drivers/clk/qcom/clock-sc7280.c b/drivers/clk/qcom/clock-sc7280.c
> index 7b6ed826023..acdaccf7462 100644
> --- a/drivers/clk/qcom/clock-sc7280.c
> +++ b/drivers/clk/qcom/clock-sc7280.c
> @@ -155,6 +155,8 @@ static const struct gate_clk sc7280_clks[] = {
>  	GATE_CLK(GCC_UFS_1_CLKREF_EN, 0x8c000, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_AHB_CLK, 0x14008, BIT(0)),
>  	GATE_CLK(GCC_SDCC2_APPS_CLK, 0x14004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_AHB_CLK,  0x75004, BIT(0)),
> +	GATE_CLK(GCC_SDCC1_APPS_CLK, 0x75008, BIT(0)),
>  };
>  
>  static int sc7280_enable(struct clk *clk)
> -- 
> 2.50.1 (Apple Git-155)
> 

Re: [PATCH] clk: qcom: sc7280: add missing SDCC1 clocks

[Casey Connolly]

On Fri, 27 Feb 2026 01:02:17 +0530, Ajit Singh wrote:
> clk: qcom: sc7280: add missing SDCC1 clocks

Applied, thanks!

First and last time I use b4 review, the commit shas are wrong but you can find the patches in https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commits/casey/qcom-main-13Apr2026?ref_type=heads

Apologies


[1/1] clk: qcom: sc7280: add missing SDCC1 clocks
      https://source.denx.de/u-boot/custodians/u-boot-snapdragon/-/commit/e3da8a860343

Best regards,
-- 
// Casey (she/they)