RE: [meta-arago] [dunfell/master][PATCH v2] tisdk-uenv: remove uEnv.txt for k3

["Humphreys, Jonathan" <j-humphreys@ti.com>]

Ryan, I do not see this patch applied to master.  Can you check?

Thanks
Jon

-----Original Message-----
From: meta-arago@lists.yoctoproject.org <meta-arago@lists.yoctoproject.org> On Behalf Of Jonathan Humphreys via lists.yoctoproject.org
Sent: Monday, June 13, 2022 11:18 AM
To: meta-arago@lists.yoctoproject.org
Subject: Re: [meta-arago] [dunfell/master][PATCH v2] tisdk-uenv: remove uEnv.txt for k3

On Thu, Jun  9, 2022 at 10:05 AM, Andrew Davis wrote:

>
> This fixup should have been done in u-boot and not in a uEnv.txt file. 
> It is not correct for all K3 anymore either. Remove it.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
> 
> Changes from v1:
>  - Subject s/tiusdk-uenv/tisdk-uenv
> 
>  .../tisdk-uenv/tisdk-uenv/k3/uEnv.txt         | 19 -------------------
>  1 file changed, 19 deletions(-)
>  delete mode 100644
> meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt
> 
> diff --git 
> a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt
> b/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt
> deleted file mode 100644
> index 80ea34f5..00000000
> --- 
> a/meta-arago-distro/recipes-tisdk/tisdk-uenv/tisdk-uenv/k3/uEnv.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -# This uEnv.txt file can contain additional environment settings that 
> you -# want to set in U-Boot at boot time.  This can be simple 
> variables such -# as the serverip or custom variables.  The format of this file is:
> -#    variable=value
> -# NOTE: This file will be evaluated after the bootcmd is run and the
> -#       bootcmd must be set to load this file if it exists (this is the
> -#       default on all newer U-Boot images.  This also means that some
> -#       variables such as bootdelay cannot be changed by this file since
> -#       it is not evaluated until the bootcmd is run.
> -

Shouldn't we keep the above, as this is generic information about how to use uEnv.txt and when it is invoked?

> -# The specific board is not able to be automatically detected. The 
> below is a -# workaround to set a sane default incase the user has not 
> manually configured -# a specific board.
> -def_board_name="am65x"
> -
> -# Check if using default board_name when name_overlays is not set 
> -check_for_board=if test $name_overlays; then echo "Using board_name = 
> $board_name"; else setenv board_name $def_board_name; fi
> -
> -uenvcmd=run check_for_board; run findfdt
> --
> 2.36.1
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13896): https://lists.yoctoproject.org/g/meta-arago/message/13896
Mute This Topic: https://lists.yoctoproject.org/mt/91650730/3617106
Group Owner: meta-arago+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [j-humphreys@ti.com]
-=-=-=-=-=-=-=-=-=-=-=-