From: Lu Baolu <baolu.lu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Joerg Roedel <jroedel@suse.de>, Will Deacon <will@kernel.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file
Date: Wed, 16 Feb 2022 15:03:23 +0800 [thread overview]
Message-ID: <ae863355-3f44-5eae-4f35-90a62cb2d89f@linux.intel.com> (raw)
In-Reply-To: <Ygt3jibBVRyCn909@smile.fi.intel.com>
On 2/15/22 5:51 PM, Andy Shevchenko wrote:
> On Tue, Feb 15, 2022 at 09:31:37AM +0800, Lu Baolu wrote:
>> On 2/14/22 9:27 PM, Joerg Roedel wrote:
>>> On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote:
>
> ...
>
>>>> +extern const struct iommu_ops intel_iommu_ops;
>
>>> The intel_iommu_ops symbol is only used in drivers/iommu/intel, so I
>>> would prefer a header in that directory. But I leave that up to Baolu to
>>> decide.
>>
>> Agreed. I also have a plan to split them out into a internal header.
>
> The above change is hanging for more than a year, can we apply it and then
> you can do a split?
>
Yeah. This is my plan. The include/linux/intel-iommu.h also keeps other
internal only helpers. It worth a separated cleanup patch.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <joro@8bytes.org>,
Joerg Roedel <jroedel@suse.de>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file
Date: Wed, 16 Feb 2022 15:03:23 +0800 [thread overview]
Message-ID: <ae863355-3f44-5eae-4f35-90a62cb2d89f@linux.intel.com> (raw)
In-Reply-To: <Ygt3jibBVRyCn909@smile.fi.intel.com>
On 2/15/22 5:51 PM, Andy Shevchenko wrote:
> On Tue, Feb 15, 2022 at 09:31:37AM +0800, Lu Baolu wrote:
>> On 2/14/22 9:27 PM, Joerg Roedel wrote:
>>> On Mon, Feb 07, 2022 at 04:12:40PM +0200, Andy Shevchenko wrote:
>
> ...
>
>>>> +extern const struct iommu_ops intel_iommu_ops;
>
>>> The intel_iommu_ops symbol is only used in drivers/iommu/intel, so I
>>> would prefer a header in that directory. But I leave that up to Baolu to
>>> decide.
>>
>> Agreed. I also have a plan to split them out into a internal header.
>
> The above change is hanging for more than a year, can we apply it and then
> you can do a split?
>
Yeah. This is my plan. The include/linux/intel-iommu.h also keeps other
internal only helpers. It worth a separated cleanup patch.
Best regards,
baolu
next prev parent reply other threads:[~2022-02-16 7:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 14:12 [PATCH v2 1/1] iommu/vt-d: Move intel_iommu_ops to header file Andy Shevchenko
2022-02-07 14:12 ` Andy Shevchenko
2022-02-09 11:56 ` Andy Shevchenko
2022-02-09 11:56 ` Andy Shevchenko
2022-02-14 13:27 ` Joerg Roedel
2022-02-14 13:27 ` Joerg Roedel
2022-02-15 1:31 ` Lu Baolu
2022-02-15 1:31 ` Lu Baolu
2022-02-15 9:51 ` Andy Shevchenko
2022-02-15 9:51 ` Andy Shevchenko
2022-02-16 7:03 ` Lu Baolu [this message]
2022-02-16 7:03 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae863355-3f44-5eae-4f35-90a62cb2d89f@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.