From: Peter Xu <peterx@redhat.com>
To: Trieu Huynh <vikingtc4@gmail.com>
Cc: "Claudio Fontana" <cfontana@suse.de>,
"Fabiano Rosas" <farosas@suse.de>,
qemu-devel@nongnu.org, "Jim Fehlig" <jfehlig@suse.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 0/2] migration: include timing and RAM stats on destination when query-migrate
Date: Thu, 16 Apr 2026 14:50:29 -0400 [thread overview]
Message-ID: <aeEvdT0gzpOfDksG@x1.local> (raw)
In-Reply-To: <spjcuqt626vglmkxxal6ntrttaiwlapcbltrix5eslmyr7yirx@cegi5c5lvay2>
On Thu, Apr 16, 2026 at 11:53:55PM +0700, Trieu Huynh wrote:
> Hello Peter,
Hi, Trieu,
> One specific use case where the source is completely unavailable is loading
> from a migration snapshot (non-live).
> In this scenario, there is no active source QEMU to query_for_stats. The
> dst (IMHO) is the only entity that can report how long the loading took
> and how much data was actually processed from the snapshot file.
> This use case is a little bit niche but still a valid one though, isn't it?
Yes it's in general valid, but it also depends. There's a reason that QEMU
supported load snapshot over the years and nobody was asking for it. I
believe it's because people simply don't need it.
Load snapshot, unlike generic form of live migration, doesn't have much
uncertainty on its own. It should either succeed after a while, or fail
with an error. People should not expect to need to query anything.
It will likely, and should, hold true even if with async load snapshot in
the future.
It is only valid in that it might be useful for developers who works on
snapshot, especially tuning the performance. But then it also means we
shouldn't expose it to an user API (QMP is in this case). For dev only
reportings, we should rely on trace points unless we have good reason to
make it visible to users.
In general, we don't need to add unnecessary API maint burden to ourselves
when not needed.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2026-04-16 18:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 15:26 [PATCH 0/2] migration: include timing and RAM stats on destination when query-migrate Trieu Huynh
2026-04-05 15:26 ` [PATCH 1/2] migration: track timing and received pages in MigrationIncomingState Trieu Huynh
2026-04-07 12:02 ` Claudio Fontana
2026-04-07 12:11 ` Claudio Fontana
2026-04-07 18:28 ` Trieu Huynh
2026-04-05 15:26 ` [PATCH 2/2] migration: expose RAM stats and timing on destination via query-migrate Trieu Huynh
2026-04-08 16:14 ` Claudio Fontana
2026-04-08 19:38 ` Trieu Huynh
2026-04-06 14:02 ` [PATCH 0/2] migration: include timing and RAM stats on destination when query-migrate Fabiano Rosas
2026-04-08 20:04 ` Peter Xu
2026-04-09 10:08 ` Claudio Fontana
2026-04-09 13:08 ` Fabian Grünbichler
2026-04-09 13:17 ` Claudio Fontana
2026-04-09 13:29 ` Fabian Grünbichler
2026-04-13 21:07 ` Peter Xu
2026-04-16 16:53 ` Trieu Huynh
2026-04-16 18:50 ` Peter Xu [this message]
2026-04-17 10:01 ` Trieu Huynh
2026-04-22 22:46 ` Fabiano Rosas
2026-04-23 13:22 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeEvdT0gzpOfDksG@x1.local \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=cfontana@suse.de \
--cc=farosas@suse.de \
--cc=jfehlig@suse.com \
--cc=qemu-devel@nongnu.org \
--cc=vikingtc4@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.