All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: "Claudio Fontana" <cfontana@suse.de>,
	"Trieu Huynh" <vikingtc4@gmail.com>,
	qemu-devel@nongnu.org, "Jim Fehlig" <jfehlig@suse.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 0/2] migration: include timing and RAM stats on destination when query-migrate
Date: Thu, 23 Apr 2026 09:22:40 -0400	[thread overview]
Message-ID: <aeodIPAxxCK-D3Qk@x1.local> (raw)
In-Reply-To: <87ldeeehpm.fsf@suse.de>

On Wed, Apr 22, 2026 at 07:46:45PM -0300, Fabiano Rosas wrote:
> I came to the thread to suggest this, but I see you already mentioned
> it. I'm not sure what you mean by "forward", but I was actually thinking
> "migrate". Do we have precedent for migrating a QAPI object? Do we want
> to have it? =) Put that MigrationInfo at the end of the stream and we'd
> have a nice symmetric interface for query-migrate in both src and dst.

Do we need to "migrate" it, say, using VMSD data structures?

We could, but I'm not yet sure if it's a good idea, especially if we should
make that as part of ABI.  It may add some unnecessary burden to us.

> 
> (we have plans to deal with QEMU_VM_VMDESCRIPTION at some point anyway,
> we could maybe rework that end section into something useful)

That might still be a bit early phase to contain all the stats info. For
example, the real downtime needs to be calculated until src receiving the
ACK, that should be after dest receive QEMU_VM_VMDESCRIPTION, IIRC.  So if
we want to at least forward the downtime info, that might be too early.

In all cases, I still think we should evaluate libvirt solution before any
other explorations.. because so far we still don't know why it can't be
done, and it's the simplest afaiu.

-- 
Peter Xu



      reply	other threads:[~2026-04-23 13:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 15:26 [PATCH 0/2] migration: include timing and RAM stats on destination when query-migrate Trieu Huynh
2026-04-05 15:26 ` [PATCH 1/2] migration: track timing and received pages in MigrationIncomingState Trieu Huynh
2026-04-07 12:02   ` Claudio Fontana
2026-04-07 12:11     ` Claudio Fontana
2026-04-07 18:28       ` Trieu Huynh
2026-04-05 15:26 ` [PATCH 2/2] migration: expose RAM stats and timing on destination via query-migrate Trieu Huynh
2026-04-08 16:14   ` Claudio Fontana
2026-04-08 19:38     ` Trieu Huynh
2026-04-06 14:02 ` [PATCH 0/2] migration: include timing and RAM stats on destination when query-migrate Fabiano Rosas
2026-04-08 20:04   ` Peter Xu
2026-04-09 10:08     ` Claudio Fontana
2026-04-09 13:08       ` Fabian Grünbichler
2026-04-09 13:17         ` Claudio Fontana
2026-04-09 13:29           ` Fabian Grünbichler
2026-04-13 21:07       ` Peter Xu
2026-04-16 16:53         ` Trieu Huynh
2026-04-16 18:50           ` Peter Xu
2026-04-17 10:01             ` Trieu Huynh
2026-04-22 22:46         ` Fabiano Rosas
2026-04-23 13:22           ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aeodIPAxxCK-D3Qk@x1.local \
    --to=peterx@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cfontana@suse.de \
    --cc=farosas@suse.de \
    --cc=jfehlig@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vikingtc4@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.