* [PATCH v2] hw/scsi: Add SCSI tape device emulation [not found] <aeEicSrfbE2sZo8w> @ 2026-04-16 18:35 ` rft0 2026-04-16 18:47 ` Rafet T 2026-04-17 9:57 ` Daniel P. Berrangé 0 siblings, 2 replies; 5+ messages in thread From: rft0 @ 2026-04-16 18:35 UTC (permalink / raw) To: qemu-devel; +Cc: berrange, pbonzini, fam, rft0 Add initial emulation of SCSI tape device supporting basic INQUIRY operation for now. Signed-off-by: rft0 <rafettaskindev@gmail.com> --- Second patch: - Add kconfig entry - Validate vendor, product, version, serial lengths hw/scsi/Kconfig | 5 + hw/scsi/meson.build | 1 + hw/scsi/scsi-tape.c | 349 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 355 insertions(+) create mode 100644 hw/scsi/scsi-tape.c diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig index 5743ee9b4d..06e7cab178 100644 --- a/hw/scsi/Kconfig +++ b/hw/scsi/Kconfig @@ -1,6 +1,11 @@ config SCSI bool +config SCSI_TAPE + bool + default y + depends on SCSI + config LSI_SCSI_PCI bool default y if PCI_DEVICES diff --git a/hw/scsi/meson.build b/hw/scsi/meson.build index 69fde0cf84..1c62115d8e 100644 --- a/hw/scsi/meson.build +++ b/hw/scsi/meson.build @@ -8,6 +8,7 @@ scsi_ss.add(files( 'scsi-disk.c', 'scsi-generic.c', )) +scsi_ss.add(when: 'CONFIG_SCSI_TAPE', if_true: files('scsi-tape.c')) scsi_ss.add(when: 'CONFIG_ESP', if_true: files('esp.c')) scsi_ss.add(when: 'CONFIG_ESP_PCI', if_true: files('esp-pci.c')) scsi_ss.add(when: 'CONFIG_LSI_SCSI_PCI', if_true: files('lsi53c895a.c')) diff --git a/hw/scsi/scsi-tape.c b/hw/scsi/scsi-tape.c new file mode 100644 index 0000000000..adbae9b4ad --- /dev/null +++ b/hw/scsi/scsi-tape.c @@ -0,0 +1,349 @@ +/* + * SCSI Tape Device emulation + * + * SPDX-License-Identifier: GPL-2.0-or-later + * + * Written by Rafet Taskin <rafettaskindev@gmail.com> + * + * SCSI Tape device emulation. + * + */ + +#include "qemu/hw-version.h" +#include "qemu/osdep.h" +#include "qapi/error.h" +#include "qemu/module.h" +#include "qemu/memalign.h" +#include "qemu/cutils.h" +#include "hw/scsi/scsi.h" +#include "scsi/constants.h" +#include "system/block-backend.h" +#include "hw/block/block.h" +#include "hw/core/qdev-properties.h" +#include "hw/core/qdev-properties-system.h" +#include "qom/object.h" + +#define SCSI_MAX_INQUIRY_LEN 256 + +#define MAX_SERIAL_LEN 36 + +#define TYPE_SCSI_TAPE "scsi-tape" + +OBJECT_DECLARE_SIMPLE_TYPE(SCSITapeState, SCSI_TAPE) + +typedef struct SCSITapeReq { + SCSIRequest req; + + uint32_t buflen; + struct iovec iov; + + QEMUIOVector qiov; +} SCSITapeReq; + +struct SCSITapeState { + SCSIDevice qdev; + + char *vendor; + char *product; + char *version; + char *serial; +}; + +static void scsi_free_request(SCSIRequest *req) +{ + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); + + qemu_vfree(r->iov.iov_base); +} + +static uint8_t *scsi_get_buf(SCSIRequest *req) +{ + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); + + return (uint8_t *)r->iov.iov_base; +} + +static void scsi_init_iovec(SCSITapeReq *r, size_t size) +{ + if (!r->iov.iov_base) { + r->buflen = size; + r->iov.iov_base = qemu_memalign(qemu_real_host_page_size(), size); + } + + r->iov.iov_len = size; + qemu_iovec_init_external(&r->qiov, &r->iov, 1); +} + +static void scsi_check_condition(SCSITapeReq *r, SCSISense sense) +{ + scsi_req_build_sense(&r->req, sense); + scsi_req_complete(&r->req, CHECK_CONDITION); +} + +static int scsi_disk_emulate_vpd_page(SCSIRequest *req, uint8_t *outbuf) +{ + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); + uint8_t page_code = req->cmd.buf[2]; + + outbuf[0] = TYPE_TAPE; + outbuf[1] = page_code; + outbuf[2] = 0x00; + outbuf[3] = 0x00; + + switch (page_code) { + case 0x00: /* Supported VPD pages */ + outbuf[4] = 0x00; /* page 0x00 (this page) */ + if (s->serial) { + outbuf[5] = 0x80; /* page 0x80 (serial number) */ + outbuf[3] = 2; /* page data length */ + return 6; + } + outbuf[3] = 1; + return 5; + + case 0x80: /* Unit Serial Number */ + if (!s->serial) { + return -1; /* not supported, caller sends INVALID_FIELD */ + } + { + int l = strlen(s->serial); + outbuf[3] = l; + memcpy(&outbuf[4], s->serial, l); + return 4 + l; + } + + default: + return -1; /* unsupported VPD page */ + } +} + +static int scsi_tape_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf) +{ + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); + int buflen; + + if (req->cmd.buf[1] & 0x1) { + return scsi_disk_emulate_vpd_page(req, outbuf); + } + + /* Standard INQUIRY, not a VPD request */ + if (req->cmd.buf[2] != 0) { + return -1; + } + + /* PAGE_CODE == 0 */ + buflen = req->cmd.xfer; + if (buflen > SCSI_MAX_INQUIRY_LEN) { + buflen = SCSI_MAX_INQUIRY_LEN; + } + + outbuf[0] = TYPE_TAPE; /* 0x01 = Tape */ + outbuf[1] = 0x80; /* Always removable */ + outbuf[2] = 0x05; /* SPC-3 */ + outbuf[3] = 0x02 | 0x10; /* Format 2, HiSup */ + + if (buflen > 36) { + outbuf[4] = buflen - 5; + } else { + outbuf[4] = 36 - 5; + } + + outbuf[7] = 0x10 | (req->bus->info->tcq ? 0x02 : 0); + + strpadcpy((char *)&outbuf[16], 16, s->product, ' '); + strpadcpy((char *)&outbuf[8], 8, s->vendor, ' '); + + memset(&outbuf[32], 0, 4); + memcpy(&outbuf[32], s->version, MIN(4, strlen(s->version))); + + return buflen; +} + +/* + * > 0 - number of bytes from device to host + * < 0 - number of bytes from host to device + * = 0 - no data transfer, already completed + */ +static int32_t scsi_tape_emulate_command(SCSIRequest *req, uint8_t *buf) +{ + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); + uint8_t *outbuf; + int32_t len = 0; + uint8_t command = buf[0]; + + if (req->cmd.xfer > 65536) { + scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); + return 0; + } + r->buflen = MAX(4096, req->cmd.xfer); + scsi_init_iovec(r, r->buflen); + + outbuf = r->iov.iov_base; + memset(outbuf, 0, r->buflen); + + switch (command) { + case INQUIRY: + len = scsi_tape_emulate_inquiry(req, outbuf); + if (len < 0) { + scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); + return 0; + } + break; + + case TEST_UNIT_READY: + if (!blk_is_available(req->dev->conf.blk)) { + scsi_check_condition(r, SENSE_CODE(NO_MEDIUM)); + return 0; + } + + /* TODO: check if tape is really ready */ + scsi_req_complete(&r->req, GOOD); + return 0; + case REQUEST_SENSE: + /* TODO: returning NO SENSE for now handle it later. */ + /* 0x0: 0x70 = current errors, fixed format */ + /* 0x2: sense key (0x00 = NO SENSE) */ + /* 0x7: additional sense length */ + { + int sense_len = MIN(buf[4], 18); + memset(outbuf, 0, sense_len); + outbuf[0] = 0x70; + outbuf[2] = 0x00; + outbuf[7] = 10; + len = sense_len; + } + break; + + case REWIND: + if (!blk_is_available(req->dev->conf.blk)) { + scsi_check_condition(r, SENSE_CODE(NO_MEDIUM)); + return 0; + } + + /* TODO: reset tape position to beginning of SIMH image */ + scsi_req_complete(&r->req, GOOD); + return 0; + + /* Add rest later */ + default: + scsi_check_condition(r, SENSE_CODE(INVALID_OPCODE)); + return 0; + } + + r->iov.iov_len = len; + return len; +} + + +/* TODO */ +static void scsi_tape_emulate_read_data(SCSIRequest *req) +{ + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); + int buflen = r->iov.iov_len; + + if (buflen) { + r->iov.iov_len = 0; + scsi_req_data(&r->req, buflen); + return; + } + + scsi_req_complete(&r->req, GOOD); +} + +/* TODO: not implemented yet */ +static void scsi_tape_emulate_write_data(SCSIRequest *req) +{ + scsi_req_complete(req, GOOD); +} + +static const SCSIReqOps scsi_tape_reqops = { + .size = sizeof(SCSITapeReq), + .free_req = scsi_free_request, + .send_command = scsi_tape_emulate_command, + .read_data = scsi_tape_emulate_read_data, + .write_data = scsi_tape_emulate_write_data, + .get_buf = scsi_get_buf, +}; + +static SCSIRequest *scsi_tape_new_request(SCSIDevice *d, uint32_t tag, + uint32_t lun, uint8_t *buf, + void *hba_private) +{ + return scsi_req_alloc(&scsi_tape_reqops, d, tag, lun, hba_private); +} + +static void scsi_tape_realize(SCSIDevice *dev, Error **errp) +{ + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, dev); + + dev->type = TYPE_TAPE; + + if (!s->qdev.conf.blk) { + error_setg(errp, "Drive property not set"); + return; + } + + if (!blk_is_inserted(s->qdev.conf.blk)) { + error_setg(errp, "Device needs media, but drive is empty"); + return; + } + + if (!s->vendor) { + s->vendor = g_strdup("QEMU"); + } else if (strlen(s->vendor) > 8) { + error_setg(errp, "Vendor must be 8 characters at most"); + return; + } + + if (!s->product) { + s->product = g_strdup("QEMU TAPE"); + } else if (strlen(s->product) > 16) { + error_setg(errp, "Product must be 16 characters at most"); + return; + } + + if (!s->version) { + s->version = g_strdup(QEMU_HW_VERSION); + } else if (strlen(s->version) > 4) { + error_setg(errp, "Version must be 4 characters at most"); + return; + } + + if (s->serial && strlen(s->serial) > 36) { + error_setg(errp, "Serial must be 36 characters at most"); + return; + } +} + +static Property scsi_tape_properties[] = { + DEFINE_PROP_DRIVE("drive", SCSITapeState, qdev.conf.blk), + DEFINE_PROP_STRING("vendor", SCSITapeState, vendor), + DEFINE_PROP_STRING("product", SCSITapeState, product), + DEFINE_PROP_STRING("ver", SCSITapeState, version), + DEFINE_PROP_STRING("serial", SCSITapeState, serial), +}; + +static void scsi_tape_class_initfn(ObjectClass *klass, const void *data) +{ + DeviceClass *dc = DEVICE_CLASS(klass); + SCSIDeviceClass *sc = SCSI_DEVICE_CLASS(klass); + + sc->realize = scsi_tape_realize; + sc->alloc_req = scsi_tape_new_request; + dc->desc = "SCSI Tape"; + device_class_set_props(dc, scsi_tape_properties); +} + +static const TypeInfo scsi_tape_info = { + .name = TYPE_SCSI_TAPE, + .parent = TYPE_SCSI_DEVICE, + .instance_size = sizeof(SCSITapeState), + .class_init = scsi_tape_class_initfn, +}; + +static void scsi_tape_register_types(void) +{ + type_register_static(&scsi_tape_info); +} + +type_init(scsi_tape_register_types) -- 2.47.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/scsi: Add SCSI tape device emulation 2026-04-16 18:35 ` [PATCH v2] hw/scsi: Add SCSI tape device emulation rft0 @ 2026-04-16 18:47 ` Rafet T 2026-04-17 9:57 ` Daniel P. Berrangé 1 sibling, 0 replies; 5+ messages in thread From: Rafet T @ 2026-04-16 18:47 UTC (permalink / raw) To: qemu-devel; +Cc: berrange, pbonzini, fam [-- Attachment #1: Type: text/plain, Size: 12114 bytes --] this is continuation of https://lore.kernel.org/qemu-devel/aeEicSrfbE2sZo8w@redhat.com/T/#t On Thu, Apr 16, 2026 at 9:36 PM rft0 <rafettaskindev@gmail.com> wrote: > Add initial emulation of SCSI tape device supporting basic > INQUIRY operation for now. > > Signed-off-by: rft0 <rafettaskindev@gmail.com> > --- > Second patch: > - Add kconfig entry > - Validate vendor, product, version, serial lengths > > hw/scsi/Kconfig | 5 + > hw/scsi/meson.build | 1 + > hw/scsi/scsi-tape.c | 349 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 355 insertions(+) > create mode 100644 hw/scsi/scsi-tape.c > > diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig > index 5743ee9b4d..06e7cab178 100644 > --- a/hw/scsi/Kconfig > +++ b/hw/scsi/Kconfig > @@ -1,6 +1,11 @@ > config SCSI > bool > > +config SCSI_TAPE > + bool > + default y > + depends on SCSI > + > config LSI_SCSI_PCI > bool > default y if PCI_DEVICES > diff --git a/hw/scsi/meson.build b/hw/scsi/meson.build > index 69fde0cf84..1c62115d8e 100644 > --- a/hw/scsi/meson.build > +++ b/hw/scsi/meson.build > @@ -8,6 +8,7 @@ scsi_ss.add(files( > 'scsi-disk.c', > 'scsi-generic.c', > )) > +scsi_ss.add(when: 'CONFIG_SCSI_TAPE', if_true: files('scsi-tape.c')) > scsi_ss.add(when: 'CONFIG_ESP', if_true: files('esp.c')) > scsi_ss.add(when: 'CONFIG_ESP_PCI', if_true: files('esp-pci.c')) > scsi_ss.add(when: 'CONFIG_LSI_SCSI_PCI', if_true: files('lsi53c895a.c')) > diff --git a/hw/scsi/scsi-tape.c b/hw/scsi/scsi-tape.c > new file mode 100644 > index 0000000000..adbae9b4ad > --- /dev/null > +++ b/hw/scsi/scsi-tape.c > @@ -0,0 +1,349 @@ > +/* > + * SCSI Tape Device emulation > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > + * > + * Written by Rafet Taskin <rafettaskindev@gmail.com> > + * > + * SCSI Tape device emulation. > + * > + */ > + > +#include "qemu/hw-version.h" > +#include "qemu/osdep.h" > +#include "qapi/error.h" > +#include "qemu/module.h" > +#include "qemu/memalign.h" > +#include "qemu/cutils.h" > +#include "hw/scsi/scsi.h" > +#include "scsi/constants.h" > +#include "system/block-backend.h" > +#include "hw/block/block.h" > +#include "hw/core/qdev-properties.h" > +#include "hw/core/qdev-properties-system.h" > +#include "qom/object.h" > + > +#define SCSI_MAX_INQUIRY_LEN 256 > + > +#define MAX_SERIAL_LEN 36 > + > +#define TYPE_SCSI_TAPE "scsi-tape" > + > +OBJECT_DECLARE_SIMPLE_TYPE(SCSITapeState, SCSI_TAPE) > + > +typedef struct SCSITapeReq { > + SCSIRequest req; > + > + uint32_t buflen; > + struct iovec iov; > + > + QEMUIOVector qiov; > +} SCSITapeReq; > + > +struct SCSITapeState { > + SCSIDevice qdev; > + > + char *vendor; > + char *product; > + char *version; > + char *serial; > +}; > + > +static void scsi_free_request(SCSIRequest *req) > +{ > + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); > + > + qemu_vfree(r->iov.iov_base); > +} > + > +static uint8_t *scsi_get_buf(SCSIRequest *req) > +{ > + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); > + > + return (uint8_t *)r->iov.iov_base; > +} > + > +static void scsi_init_iovec(SCSITapeReq *r, size_t size) > +{ > + if (!r->iov.iov_base) { > + r->buflen = size; > + r->iov.iov_base = qemu_memalign(qemu_real_host_page_size(), size); > + } > + > + r->iov.iov_len = size; > + qemu_iovec_init_external(&r->qiov, &r->iov, 1); > +} > + > +static void scsi_check_condition(SCSITapeReq *r, SCSISense sense) > +{ > + scsi_req_build_sense(&r->req, sense); > + scsi_req_complete(&r->req, CHECK_CONDITION); > +} > + > +static int scsi_disk_emulate_vpd_page(SCSIRequest *req, uint8_t *outbuf) > +{ > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); > + uint8_t page_code = req->cmd.buf[2]; > + > + outbuf[0] = TYPE_TAPE; > + outbuf[1] = page_code; > + outbuf[2] = 0x00; > + outbuf[3] = 0x00; > + > + switch (page_code) { > + case 0x00: /* Supported VPD pages */ > + outbuf[4] = 0x00; /* page 0x00 (this page) */ > + if (s->serial) { > + outbuf[5] = 0x80; /* page 0x80 (serial number) */ > + outbuf[3] = 2; /* page data length */ > + return 6; > + } > + outbuf[3] = 1; > + return 5; > + > + case 0x80: /* Unit Serial Number */ > + if (!s->serial) { > + return -1; /* not supported, caller sends INVALID_FIELD */ > + } > + { > + int l = strlen(s->serial); > + outbuf[3] = l; > + memcpy(&outbuf[4], s->serial, l); > + return 4 + l; > + } > + > + default: > + return -1; /* unsupported VPD page */ > + } > +} > + > +static int scsi_tape_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf) > +{ > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); > + int buflen; > + > + if (req->cmd.buf[1] & 0x1) { > + return scsi_disk_emulate_vpd_page(req, outbuf); > + } > + > + /* Standard INQUIRY, not a VPD request */ > + if (req->cmd.buf[2] != 0) { > + return -1; > + } > + > + /* PAGE_CODE == 0 */ > + buflen = req->cmd.xfer; > + if (buflen > SCSI_MAX_INQUIRY_LEN) { > + buflen = SCSI_MAX_INQUIRY_LEN; > + } > + > + outbuf[0] = TYPE_TAPE; /* 0x01 = Tape */ > + outbuf[1] = 0x80; /* Always removable */ > + outbuf[2] = 0x05; /* SPC-3 */ > + outbuf[3] = 0x02 | 0x10; /* Format 2, HiSup */ > + > + if (buflen > 36) { > + outbuf[4] = buflen - 5; > + } else { > + outbuf[4] = 36 - 5; > + } > + > + outbuf[7] = 0x10 | (req->bus->info->tcq ? 0x02 : 0); > + > + strpadcpy((char *)&outbuf[16], 16, s->product, ' '); > + strpadcpy((char *)&outbuf[8], 8, s->vendor, ' '); > + > + memset(&outbuf[32], 0, 4); > + memcpy(&outbuf[32], s->version, MIN(4, strlen(s->version))); > + > + return buflen; > +} > + > +/* > + * > 0 - number of bytes from device to host > + * < 0 - number of bytes from host to device > + * = 0 - no data transfer, already completed > + */ > +static int32_t scsi_tape_emulate_command(SCSIRequest *req, uint8_t *buf) > +{ > + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); > + uint8_t *outbuf; > + int32_t len = 0; > + uint8_t command = buf[0]; > + > + if (req->cmd.xfer > 65536) { > + scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); > + return 0; > + } > + r->buflen = MAX(4096, req->cmd.xfer); > + scsi_init_iovec(r, r->buflen); > + > + outbuf = r->iov.iov_base; > + memset(outbuf, 0, r->buflen); > + > + switch (command) { > + case INQUIRY: > + len = scsi_tape_emulate_inquiry(req, outbuf); > + if (len < 0) { > + scsi_check_condition(r, SENSE_CODE(INVALID_FIELD)); > + return 0; > + } > + break; > + > + case TEST_UNIT_READY: > + if (!blk_is_available(req->dev->conf.blk)) { > + scsi_check_condition(r, SENSE_CODE(NO_MEDIUM)); > + return 0; > + } > + > + /* TODO: check if tape is really ready */ > + scsi_req_complete(&r->req, GOOD); > + return 0; > + case REQUEST_SENSE: > + /* TODO: returning NO SENSE for now handle it later. */ > + /* 0x0: 0x70 = current errors, fixed format */ > + /* 0x2: sense key (0x00 = NO SENSE) */ > + /* 0x7: additional sense length */ > + { > + int sense_len = MIN(buf[4], 18); > + memset(outbuf, 0, sense_len); > + outbuf[0] = 0x70; > + outbuf[2] = 0x00; > + outbuf[7] = 10; > + len = sense_len; > + } > + break; > + > + case REWIND: > + if (!blk_is_available(req->dev->conf.blk)) { > + scsi_check_condition(r, SENSE_CODE(NO_MEDIUM)); > + return 0; > + } > + > + /* TODO: reset tape position to beginning of SIMH image */ > + scsi_req_complete(&r->req, GOOD); > + return 0; > + > + /* Add rest later */ > + default: > + scsi_check_condition(r, SENSE_CODE(INVALID_OPCODE)); > + return 0; > + } > + > + r->iov.iov_len = len; > + return len; > +} > + > + > +/* TODO */ > +static void scsi_tape_emulate_read_data(SCSIRequest *req) > +{ > + SCSITapeReq *r = DO_UPCAST(SCSITapeReq, req, req); > + int buflen = r->iov.iov_len; > + > + if (buflen) { > + r->iov.iov_len = 0; > + scsi_req_data(&r->req, buflen); > + return; > + } > + > + scsi_req_complete(&r->req, GOOD); > +} > + > +/* TODO: not implemented yet */ > +static void scsi_tape_emulate_write_data(SCSIRequest *req) > +{ > + scsi_req_complete(req, GOOD); > +} > + > +static const SCSIReqOps scsi_tape_reqops = { > + .size = sizeof(SCSITapeReq), > + .free_req = scsi_free_request, > + .send_command = scsi_tape_emulate_command, > + .read_data = scsi_tape_emulate_read_data, > + .write_data = scsi_tape_emulate_write_data, > + .get_buf = scsi_get_buf, > +}; > + > +static SCSIRequest *scsi_tape_new_request(SCSIDevice *d, uint32_t tag, > + uint32_t lun, uint8_t *buf, > + void *hba_private) > +{ > + return scsi_req_alloc(&scsi_tape_reqops, d, tag, lun, hba_private); > +} > + > +static void scsi_tape_realize(SCSIDevice *dev, Error **errp) > +{ > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, dev); > + > + dev->type = TYPE_TAPE; > + > + if (!s->qdev.conf.blk) { > + error_setg(errp, "Drive property not set"); > + return; > + } > + > + if (!blk_is_inserted(s->qdev.conf.blk)) { > + error_setg(errp, "Device needs media, but drive is empty"); > + return; > + } > + > + if (!s->vendor) { > + s->vendor = g_strdup("QEMU"); > + } else if (strlen(s->vendor) > 8) { > + error_setg(errp, "Vendor must be 8 characters at most"); > + return; > + } > + > + if (!s->product) { > + s->product = g_strdup("QEMU TAPE"); > + } else if (strlen(s->product) > 16) { > + error_setg(errp, "Product must be 16 characters at most"); > + return; > + } > + > + if (!s->version) { > + s->version = g_strdup(QEMU_HW_VERSION); > + } else if (strlen(s->version) > 4) { > + error_setg(errp, "Version must be 4 characters at most"); > + return; > + } > + > + if (s->serial && strlen(s->serial) > 36) { > + error_setg(errp, "Serial must be 36 characters at most"); > + return; > + } > +} > + > +static Property scsi_tape_properties[] = { > + DEFINE_PROP_DRIVE("drive", SCSITapeState, qdev.conf.blk), > + DEFINE_PROP_STRING("vendor", SCSITapeState, vendor), > + DEFINE_PROP_STRING("product", SCSITapeState, product), > + DEFINE_PROP_STRING("ver", SCSITapeState, version), > + DEFINE_PROP_STRING("serial", SCSITapeState, serial), > +}; > + > +static void scsi_tape_class_initfn(ObjectClass *klass, const void *data) > +{ > + DeviceClass *dc = DEVICE_CLASS(klass); > + SCSIDeviceClass *sc = SCSI_DEVICE_CLASS(klass); > + > + sc->realize = scsi_tape_realize; > + sc->alloc_req = scsi_tape_new_request; > + dc->desc = "SCSI Tape"; > + device_class_set_props(dc, scsi_tape_properties); > +} > + > +static const TypeInfo scsi_tape_info = { > + .name = TYPE_SCSI_TAPE, > + .parent = TYPE_SCSI_DEVICE, > + .instance_size = sizeof(SCSITapeState), > + .class_init = scsi_tape_class_initfn, > +}; > + > +static void scsi_tape_register_types(void) > +{ > + type_register_static(&scsi_tape_info); > +} > + > +type_init(scsi_tape_register_types) > -- > 2.47.3 > > [-- Attachment #2: Type: text/html, Size: 14841 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/scsi: Add SCSI tape device emulation 2026-04-16 18:35 ` [PATCH v2] hw/scsi: Add SCSI tape device emulation rft0 2026-04-16 18:47 ` Rafet T @ 2026-04-17 9:57 ` Daniel P. Berrangé 2026-04-17 10:22 ` Rafet T 1 sibling, 1 reply; 5+ messages in thread From: Daniel P. Berrangé @ 2026-04-17 9:57 UTC (permalink / raw) To: rft0; +Cc: qemu-devel, pbonzini, fam On Thu, Apr 16, 2026 at 09:35:40PM +0300, rft0 wrote: > Add initial emulation of SCSI tape device supporting basic > INQUIRY operation for now. > > Signed-off-by: rft0 <rafettaskindev@gmail.com> > --- > Second patch: > - Add kconfig entry > - Validate vendor, product, version, serial lengths > > hw/scsi/Kconfig | 5 + > hw/scsi/meson.build | 1 + > hw/scsi/scsi-tape.c | 349 ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 355 insertions(+) > create mode 100644 hw/scsi/scsi-tape.c > > diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig > index 5743ee9b4d..06e7cab178 100644 > --- a/hw/scsi/Kconfig > +++ b/hw/scsi/Kconfig > @@ -1,6 +1,11 @@ > config SCSI > bool > > +config SCSI_TAPE > + bool > + default y > + depends on SCSI > + > config LSI_SCSI_PCI > bool > default y if PCI_DEVICES > diff --git a/hw/scsi/meson.build b/hw/scsi/meson.build > index 69fde0cf84..1c62115d8e 100644 > --- a/hw/scsi/meson.build > +++ b/hw/scsi/meson.build > @@ -8,6 +8,7 @@ scsi_ss.add(files( > 'scsi-disk.c', > 'scsi-generic.c', > )) > +scsi_ss.add(when: 'CONFIG_SCSI_TAPE', if_true: files('scsi-tape.c')) > scsi_ss.add(when: 'CONFIG_ESP', if_true: files('esp.c')) > scsi_ss.add(when: 'CONFIG_ESP_PCI', if_true: files('esp-pci.c')) > scsi_ss.add(when: 'CONFIG_LSI_SCSI_PCI', if_true: files('lsi53c895a.c')) > diff --git a/hw/scsi/scsi-tape.c b/hw/scsi/scsi-tape.c > new file mode 100644 > index 0000000000..adbae9b4ad > --- /dev/null > +++ b/hw/scsi/scsi-tape.c > @@ -0,0 +1,349 @@ > +/* > + * SCSI Tape Device emulation > + * > + * SPDX-License-Identifier: GPL-2.0-or-later > + * > + * Written by Rafet Taskin <rafettaskindev@gmail.com> > + * > + * SCSI Tape device emulation. > + * > + */ > + > +#include "qemu/hw-version.h" > +#include "qemu/osdep.h" > +#include "qapi/error.h" > +#include "qemu/module.h" > +#include "qemu/memalign.h" > +#include "qemu/cutils.h" > +#include "hw/scsi/scsi.h" > +#include "scsi/constants.h" > +#include "system/block-backend.h" > +#include "hw/block/block.h" > +#include "hw/core/qdev-properties.h" > +#include "hw/core/qdev-properties-system.h" > +#include "qom/object.h" > + > +#define SCSI_MAX_INQUIRY_LEN 256 > + > +#define MAX_SERIAL_LEN 36 This doesn't appear to be used - the value is just hardcoded at time of use. Can we use that, and also add constants for the max product, vendor and version fields, since those magic constants are used several times over > +static int scsi_disk_emulate_vpd_page(SCSIRequest *req, uint8_t *outbuf) > +{ > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); > + uint8_t page_code = req->cmd.buf[2]; > + > + outbuf[0] = TYPE_TAPE; > + outbuf[1] = page_code; > + outbuf[2] = 0x00; > + outbuf[3] = 0x00; > + > + switch (page_code) { > + case 0x00: /* Supported VPD pages */ > + outbuf[4] = 0x00; /* page 0x00 (this page) */ > + if (s->serial) { > + outbuf[5] = 0x80; /* page 0x80 (serial number) */ > + outbuf[3] = 2; /* page data length */ > + return 6; > + } > + outbuf[3] = 1; > + return 5; > + > + case 0x80: /* Unit Serial Number */ > + if (!s->serial) { > + return -1; /* not supported, caller sends INVALID_FIELD */ > + } > + { > + int l = strlen(s->serial); > + outbuf[3] = l; > + memcpy(&outbuf[4], s->serial, l); strpadcpy is probably a better idea, as this leaves the tail of the buffer uninitialized and does not include a NUL terminator. Even if the caller has initialized the buffer with nuls, it is more reassuring to reviewers if we explicitly pad here. Use MAX_SERIAL_LEN here too with strpadcpy > + return 4 + l; > + } > + > + default: > + return -1; /* unsupported VPD page */ > + } > +} > + > +static int scsi_tape_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf) > +{ > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); > + int buflen; > + > + if (req->cmd.buf[1] & 0x1) { > + return scsi_disk_emulate_vpd_page(req, outbuf); > + } > + > + /* Standard INQUIRY, not a VPD request */ > + if (req->cmd.buf[2] != 0) { > + return -1; > + } > + > + /* PAGE_CODE == 0 */ > + buflen = req->cmd.xfer; > + if (buflen > SCSI_MAX_INQUIRY_LEN) { > + buflen = SCSI_MAX_INQUIRY_LEN; > + } > + > + outbuf[0] = TYPE_TAPE; /* 0x01 = Tape */ > + outbuf[1] = 0x80; /* Always removable */ > + outbuf[2] = 0x05; /* SPC-3 */ > + outbuf[3] = 0x02 | 0x10; /* Format 2, HiSup */ > + > + if (buflen > 36) { > + outbuf[4] = buflen - 5; > + } else { > + outbuf[4] = 36 - 5; > + } > + > + outbuf[7] = 0x10 | (req->bus->info->tcq ? 0x02 : 0); > + > + strpadcpy((char *)&outbuf[16], 16, s->product, ' '); > + strpadcpy((char *)&outbuf[8], 8, s->vendor, ' '); The 2nd arg here can use MAX_VENDOR_LEN / MAX_PRODUCT_LEN > + > + memset(&outbuf[32], 0, 4); > + memcpy(&outbuf[32], s->version, MIN(4, strlen(s->version))); Why not use strpadcpy like the two lines above. Also MAX_VERSION_LEN constant would be wise. > + > + return buflen; > +} > +static void scsi_tape_realize(SCSIDevice *dev, Error **errp) > +{ > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, dev); > + > + dev->type = TYPE_TAPE; > + > + if (!s->qdev.conf.blk) { > + error_setg(errp, "Drive property not set"); > + return; > + } > + > + if (!blk_is_inserted(s->qdev.conf.blk)) { > + error_setg(errp, "Device needs media, but drive is empty"); > + return; > + } > + > + if (!s->vendor) { > + s->vendor = g_strdup("QEMU"); > + } else if (strlen(s->vendor) > 8) { > + error_setg(errp, "Vendor must be 8 characters at most"); > + return; > + } Get rid of the "else" here and in the checks below - we want to sanity check that the static constant is not oversized too, especially for QEMU_HW_VERSION. Also use the constants for max length and include the string in the error message . IOW more like this code: if (!s->vendor) { s->vendor = g_strdup("QEMU"); } if (strlen(s->vendor) > MAX_VENDOR_LEN) { error_setg(errp, "Vendor '%s' must be %d characters at most", s->vendor, MAX_VENDOR_LEN); return; } > + if (!s->product) { > + s->product = g_strdup("QEMU TAPE"); > + } else if (strlen(s->product) > 16) { > + error_setg(errp, "Product must be 16 characters at most"); > + return; > + } > + > + if (!s->version) { > + s->version = g_strdup(QEMU_HW_VERSION); > + } else if (strlen(s->version) > 4) { > + error_setg(errp, "Version must be 4 characters at most"); > + return; > + } > + > + if (s->serial && strlen(s->serial) > 36) { > + error_setg(errp, "Serial must be 36 characters at most"); > + return; > + } > +} With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :| ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/scsi: Add SCSI tape device emulation 2026-04-17 9:57 ` Daniel P. Berrangé @ 2026-04-17 10:22 ` Rafet T 2026-04-17 10:27 ` Daniel P. Berrangé 0 siblings, 1 reply; 5+ messages in thread From: Rafet T @ 2026-04-17 10:22 UTC (permalink / raw) To: Daniel P. Berrangé; +Cc: qemu-devel, pbonzini, fam [-- Attachment #1: Type: text/plain, Size: 8250 bytes --] Hello Daniel, I would like to continue but Helge said only choosen applicant should work on this. ( https://lore.kernel.org/qemu-devel/aeEicSrfbE2sZo8w@redhat.com/T/#t) With regards, Rafet On Fri, Apr 17, 2026, 12:57 Daniel P. Berrangé <berrange@redhat.com> wrote: > On Thu, Apr 16, 2026 at 09:35:40PM +0300, rft0 wrote: > > Add initial emulation of SCSI tape device supporting basic > > INQUIRY operation for now. > > > > Signed-off-by: rft0 <rafettaskindev@gmail.com> > > --- > > Second patch: > > - Add kconfig entry > > - Validate vendor, product, version, serial lengths > > > > hw/scsi/Kconfig | 5 + > > hw/scsi/meson.build | 1 + > > hw/scsi/scsi-tape.c | 349 ++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 355 insertions(+) > > create mode 100644 hw/scsi/scsi-tape.c > > > > diff --git a/hw/scsi/Kconfig b/hw/scsi/Kconfig > > index 5743ee9b4d..06e7cab178 100644 > > --- a/hw/scsi/Kconfig > > +++ b/hw/scsi/Kconfig > > @@ -1,6 +1,11 @@ > > config SCSI > > bool > > > > +config SCSI_TAPE > > + bool > > + default y > > + depends on SCSI > > + > > config LSI_SCSI_PCI > > bool > > default y if PCI_DEVICES > > diff --git a/hw/scsi/meson.build b/hw/scsi/meson.build > > index 69fde0cf84..1c62115d8e 100644 > > --- a/hw/scsi/meson.build > > +++ b/hw/scsi/meson.build > > @@ -8,6 +8,7 @@ scsi_ss.add(files( > > 'scsi-disk.c', > > 'scsi-generic.c', > > )) > > +scsi_ss.add(when: 'CONFIG_SCSI_TAPE', if_true: files('scsi-tape.c')) > > scsi_ss.add(when: 'CONFIG_ESP', if_true: files('esp.c')) > > scsi_ss.add(when: 'CONFIG_ESP_PCI', if_true: files('esp-pci.c')) > > scsi_ss.add(when: 'CONFIG_LSI_SCSI_PCI', if_true: files('lsi53c895a.c')) > > diff --git a/hw/scsi/scsi-tape.c b/hw/scsi/scsi-tape.c > > new file mode 100644 > > index 0000000000..adbae9b4ad > > --- /dev/null > > +++ b/hw/scsi/scsi-tape.c > > @@ -0,0 +1,349 @@ > > +/* > > + * SCSI Tape Device emulation > > + * > > + * SPDX-License-Identifier: GPL-2.0-or-later > > + * > > + * Written by Rafet Taskin <rafettaskindev@gmail.com> > > + * > > + * SCSI Tape device emulation. > > + * > > + */ > > + > > +#include "qemu/hw-version.h" > > +#include "qemu/osdep.h" > > +#include "qapi/error.h" > > +#include "qemu/module.h" > > +#include "qemu/memalign.h" > > +#include "qemu/cutils.h" > > +#include "hw/scsi/scsi.h" > > +#include "scsi/constants.h" > > +#include "system/block-backend.h" > > +#include "hw/block/block.h" > > +#include "hw/core/qdev-properties.h" > > +#include "hw/core/qdev-properties-system.h" > > +#include "qom/object.h" > > + > > +#define SCSI_MAX_INQUIRY_LEN 256 > > + > > +#define MAX_SERIAL_LEN 36 > > This doesn't appear to be used - the value is just > hardcoded at time of use. Can we use that, and also > add constants for the max product, vendor and > version fields, since those magic constants are > used several times over > > > > +static int scsi_disk_emulate_vpd_page(SCSIRequest *req, uint8_t *outbuf) > > +{ > > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); > > + uint8_t page_code = req->cmd.buf[2]; > > + > > + outbuf[0] = TYPE_TAPE; > > + outbuf[1] = page_code; > > + outbuf[2] = 0x00; > > + outbuf[3] = 0x00; > > + > > + switch (page_code) { > > + case 0x00: /* Supported VPD pages */ > > + outbuf[4] = 0x00; /* page 0x00 (this page) */ > > + if (s->serial) { > > + outbuf[5] = 0x80; /* page 0x80 (serial number) */ > > + outbuf[3] = 2; /* page data length */ > > + return 6; > > + } > > + outbuf[3] = 1; > > + return 5; > > + > > + case 0x80: /* Unit Serial Number */ > > + if (!s->serial) { > > + return -1; /* not supported, caller sends INVALID_FIELD */ > > + } > > + { > > + int l = strlen(s->serial); > > + outbuf[3] = l; > > + memcpy(&outbuf[4], s->serial, l); > > strpadcpy is probably a better idea, as this leaves the tail of > the buffer uninitialized and does not include a NUL terminator. > Even if the caller has initialized the buffer with nuls, it is > more reassuring to reviewers if we explicitly pad here. > > Use MAX_SERIAL_LEN here too with strpadcpy > > > + return 4 + l; > > + } > > + > > + default: > > + return -1; /* unsupported VPD page */ > > + } > > +} > > + > > +static int scsi_tape_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf) > > +{ > > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, req->dev); > > + int buflen; > > + > > + if (req->cmd.buf[1] & 0x1) { > > + return scsi_disk_emulate_vpd_page(req, outbuf); > > + } > > + > > + /* Standard INQUIRY, not a VPD request */ > > + if (req->cmd.buf[2] != 0) { > > + return -1; > > + } > > + > > + /* PAGE_CODE == 0 */ > > + buflen = req->cmd.xfer; > > + if (buflen > SCSI_MAX_INQUIRY_LEN) { > > + buflen = SCSI_MAX_INQUIRY_LEN; > > + } > > + > > + outbuf[0] = TYPE_TAPE; /* 0x01 = Tape */ > > + outbuf[1] = 0x80; /* Always removable */ > > + outbuf[2] = 0x05; /* SPC-3 */ > > + outbuf[3] = 0x02 | 0x10; /* Format 2, HiSup */ > > + > > + if (buflen > 36) { > > + outbuf[4] = buflen - 5; > > + } else { > > + outbuf[4] = 36 - 5; > > + } > > + > > + outbuf[7] = 0x10 | (req->bus->info->tcq ? 0x02 : 0); > > + > > + strpadcpy((char *)&outbuf[16], 16, s->product, ' '); > > + strpadcpy((char *)&outbuf[8], 8, s->vendor, ' '); > > The 2nd arg here can use MAX_VENDOR_LEN / MAX_PRODUCT_LEN > > > + > > + memset(&outbuf[32], 0, 4); > > + memcpy(&outbuf[32], s->version, MIN(4, strlen(s->version))); > > Why not use strpadcpy like the two lines above. Also MAX_VERSION_LEN > constant would be wise. > > > + > > + return buflen; > > +} > > > +static void scsi_tape_realize(SCSIDevice *dev, Error **errp) > > +{ > > + SCSITapeState *s = DO_UPCAST(SCSITapeState, qdev, dev); > > + > > + dev->type = TYPE_TAPE; > > + > > + if (!s->qdev.conf.blk) { > > + error_setg(errp, "Drive property not set"); > > + return; > > + } > > + > > + if (!blk_is_inserted(s->qdev.conf.blk)) { > > + error_setg(errp, "Device needs media, but drive is empty"); > > + return; > > + } > > + > > + if (!s->vendor) { > > + s->vendor = g_strdup("QEMU"); > > + } else if (strlen(s->vendor) > 8) { > > + error_setg(errp, "Vendor must be 8 characters at most"); > > + return; > > + } > > Get rid of the "else" here and in the checks below - we want > to sanity check that the static constant is not oversized too, > especially for QEMU_HW_VERSION. Also use the constants for max > length and include the string in the error message . IOW more > like this code: > > if (!s->vendor) { > s->vendor = g_strdup("QEMU"); > } > if (strlen(s->vendor) > MAX_VENDOR_LEN) { > error_setg(errp, "Vendor '%s' must be %d characters at most", > s->vendor, MAX_VENDOR_LEN); > return; > } > > > > > > + if (!s->product) { > > + s->product = g_strdup("QEMU TAPE"); > > + } else if (strlen(s->product) > 16) { > > + error_setg(errp, "Product must be 16 characters at most"); > > + return; > > + } > > + > > + if (!s->version) { > > + s->version = g_strdup(QEMU_HW_VERSION); > > + } else if (strlen(s->version) > 4) { > > + error_setg(errp, "Version must be 4 characters at most"); > > + return; > > + } > > + > > + if (s->serial && strlen(s->serial) > 36) { > > + error_setg(errp, "Serial must be 36 characters at most"); > > + return; > > + } > > +} > > With regards, > Daniel > -- > |: https://berrange.com ~~ https://hachyderm.io/@berrange :| > |: https://libvirt.org ~~ https://entangle-photo.org :| > |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :| > > [-- Attachment #2: Type: text/html, Size: 11511 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] hw/scsi: Add SCSI tape device emulation 2026-04-17 10:22 ` Rafet T @ 2026-04-17 10:27 ` Daniel P. Berrangé 0 siblings, 0 replies; 5+ messages in thread From: Daniel P. Berrangé @ 2026-04-17 10:27 UTC (permalink / raw) To: Rafet T; +Cc: qemu-devel, pbonzini, fam On Fri, Apr 17, 2026 at 01:22:28PM +0300, Rafet T wrote: > Hello Daniel, > > I would like to continue but Helge said only choosen applicant should work > on this. ( > https://lore.kernel.org/qemu-devel/aeEicSrfbE2sZo8w@redhat.com/T/#t) Sorry, I missed that other message. Please follow Helge's request. With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :| ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-04-17 10:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <aeEicSrfbE2sZo8w>
2026-04-16 18:35 ` [PATCH v2] hw/scsi: Add SCSI tape device emulation rft0
2026-04-16 18:47 ` Rafet T
2026-04-17 9:57 ` Daniel P. Berrangé
2026-04-17 10:22 ` Rafet T
2026-04-17 10:27 ` Daniel P. Berrangé
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.