[PATCH] drivers/ide/ppc/mpc8xx.c - volatile fix

[PATCH] drivers/ide/ppc/mpc8xx.c - volatile fix

[Magnus Damm]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

Hello,

I fixed this in a local tree for a customer half a year ago (mvl-3.1)
and forgot to report it to the lists. Now I came across it in vanilla
2.5.10-rc3. I have not tested the fix but it is pretty obvious that
access with a non-volatile pointer to hardware is bad, at least with
gcc-3 or above.

Please apply. Or ignore if already fixed. =)

Thanks.

/ magnus (needs CC)

[-- Attachment #2: linux-2.6.9-mpc8xx-volatile.patch --]
[-- Type: application/octet-stream, Size: 377 bytes --]

--- linux-2.6.9/drivers/ide/ppc/mpc8xx.c	2004-12-11 13:05:09.000000000 +0100
+++ linux-2.6.9-mpc8xx-volatile/drivers/ide/ppc/mpc8xx.c	2004-12-11 15:49:16.000000000 +0100
@@ -172,7 +172,7 @@
 	volatile pcmcia_win_t *win;
 	volatile pcmconf8xx_t *pcmp;
 
-	uint *pgcrx;
+	volatile uint *pgcrx;
 	u32 pcmcia_phy_base;
 	u32 pcmcia_phy_end;
 	static unsigned long pcmcia_base = 0;