Re: a bug in drivers/net/macsec.c ? (ssci endianness)

Re: a bug in drivers/net/macsec.c ? (ssci endianness)

[Sabrina Dubroca]

2026-04-21, 11:37:53 +0000, Karol Gajdos (Nokia) wrote:
> Hi,
> 
> there seems to be a bug in the function filling IV for the XPN case.
> Can you confirm please ?

We expect userspace to provide the SSCI in network byte order via the
netlink API (same as SCI). As long as we're handling it that way
consistently, which I think is the case, there is no bug.

-- 
Sabrina

RE: a bug in drivers/net/macsec.c ? (ssci endianness)

[Karol Gajdos (Nokia)]

Ok, so it's not a bug, but let's say an unusual agreement between user space and kernel,
as netlink generally uses the host byte order for encoding and decoding integers.
Anyhow thanks for the clarification and the great work done on MACsec.  

Karol

-----Original Message-----
From: Sabrina Dubroca <sd@queasysnail.net> 
Sent: Tuesday, April 21, 2026 3:04 PM
To: Karol Gajdos (Nokia) <karol.gajdos@nokia.com>
Cc: netdev@vger.kernel.org
Subject: Re: a bug in drivers/net/macsec.c ? (ssci endianness)


CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.



2026-04-21, 11:37:53 +0000, Karol Gajdos (Nokia) wrote:
> Hi,
>
> there seems to be a bug in the function filling IV for the XPN case.
> Can you confirm please ?

We expect userspace to provide the SSCI in network byte order via the netlink API (same as SCI). As long as we're handling it that way consistently, which I think is the case, there is no bug.

--
Sabrina