Re: [PATCH v3 11/13] tests/functional/riscv64: Add tt-atlantis tests

[Nicholas Piggin <npiggin@gmail.com>]

On Tue, Apr 21, 2026 at 08:05:48AM +0200, Philippe Mathieu-Daudé wrote:
> On 21/4/26 07:31, Joel Stanley wrote:
> > From: Nicholas Piggin <npiggin@gmail.com>
> > 
> > Add OpenSBI and Linux boot tests for the tt-atlantis machine. Based on
> > tests/functional/riscv64/test_sifive_u.py.
> > 
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > v3:
> >   - Fix path to test files
> >   - Dedupe command line root argument
> >   - Remove unused import
> > ---
> >   MAINTAINERS                                  |  1 +
> >   tests/functional/riscv64/meson.build         |  1 +
> >   tests/functional/riscv64/test_opensbi.py     |  4 ++
> >   tests/functional/riscv64/test_tt_atlantis.py | 63 ++++++++++++++++++++
> >   4 files changed, 69 insertions(+)
> >   create mode 100755 tests/functional/riscv64/test_tt_atlantis.py
> 
> 
> > diff --git a/tests/functional/riscv64/test_tt_atlantis.py b/tests/functional/riscv64/test_tt_atlantis.py
> > new file mode 100755
> > index 000000000000..f6f4b7ceec34
> > --- /dev/null
> > +++ b/tests/functional/riscv64/test_tt_atlantis.py
> > @@ -0,0 +1,63 @@
> > +#!/usr/bin/env python3
> > +#
> > +# Functional test that boots a Linux kernel on a Tenstorrent Atlantis machine
> > +# and checks the console
> > +#
> > +# Copyright (c) Linaro Ltd.
> > +# Copyright 2026 Tenstorrent
> > +#
> > +# SPDX-License-Identifier: GPL-2.0-or-later
> > +
> > +import os
> > +
> > +from qemu_test import Asset, LinuxKernelTest
> > +
> > +
> > +class TTAtlantis(LinuxKernelTest):
> > +
> > +    ASSET_KERNEL = Asset(
> > +        'https://storage.tuxboot.com/kernels/6.11.9/riscv64/Image',
> > +        '174f8bb87f08961e54fa3fcd954a8e31f4645f6d6af4dd43983d5e9841490fb0')
> > +    ASSET_ROOTFS = Asset(
> > +        ('https://github.com/groeck/linux-build-test/raw/'
> > +         '9819da19e6eef291686fdd7b029ea00e764dc62f/rootfs/riscv64/'
> > +         'rootfs.ext2.gz'),
> > +        'b6ed95610310b7956f9bf20c4c9c0c05fea647900df441da9dfe767d24e8b28b')
> > +
> > +    def do_test_riscv64_tt_atlantis(self, connect_disk):
> > +        self.set_machine('tt-atlantis')
> > +        kernel_path = self.ASSET_KERNEL.fetch()
> > +        rootfs_path = self.uncompress(self.ASSET_ROOTFS)
> > +
> > +        self.vm.set_console()
> > +        kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'earlycon=sbi '
> > +
> > +        if connect_disk:
> > +            kernel_command_line += 'root=/dev/vda panic=-1 noreboot rootwait '
> > +            self.vm.add_args('-device',
> > +                             'virtio-blk,drive=drive0,serial=0x1234,bus=pcie.0')
> > +            self.vm.add_args('-drive',
> > +                             f'file={rootfs_path},if=none,id=drive0,format=raw')
> > +            pattern = 'Boot successful.'
> 
> Should we run a full shutdown to test up to the halting payload
> (patch #4)?

Halting payload is only used when there is no kernel given, not sure if
it's good cost/benefit to test that, it's just in case user screw up
they don't get blank screen apparent hang.

A shutdown test all the way to machine halt would be good, although I
don't know if we model that properly in the atlantis machine yet. Maybe
something to expand on later.

> 
> > +        else:
> > +            kernel_command_line += 'panic=0 noreboot '
> > +            pattern = 'Cannot open root device'
> > +
> > +        self.vm.add_args('-kernel', kernel_path,
> > +                         '-append', kernel_command_line,
> > +                         '-no-reboot')
> > +
> > +        self.vm.launch()
> > +        self.wait_for_console_pattern(pattern)
> > +
> > +        os.remove(rootfs_path)
> 
> Since you call uncompress() with implicit @target=None argument,
> scratch_file() is used:
> 
>         Construct a path for accessing/creating a scratch file
>         located relative to a temporary directory dedicated to
>         this test case. The directory and its contents will be
>         purged upon completion of the test.
> 
> So IIUC no need to remove manually. Do you have an issue with it
> to remove it manually?

No, I just copied it from tests/functional/riscv64/test_sifive_u.py :)
and looks like same pattern exists in a couple of other tests as well.

> 
> Otherwise,
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks,
Nick

> 
> > +
> > +    def test_riscv64_tt_atlantis(self):
> > +        self.do_test_riscv64_tt_atlantis(False)
> > +
> > +    def test_riscv64_tt_atlantis_disk(self):
> > +        self.do_test_riscv64_tt_atlantis(True)
> > +
> > +
> > +if __name__ == '__main__':
> > +    LinuxKernelTest.main()
> 
>